Opened 9 years ago
Closed 9 years ago
#12203 closed defect (fixed)
AM/PM is not translated by timepicker for Greek (Ελληνικά) locale — at Version 5
| Reported by: | Ryan J Ollos | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0.9 |
| Component: | i18n | Version: | |
| Severity: | normal | Keywords: | datetimepicker |
| Cc: | Branch: | ||
| Release Notes: |
Localize am/pm markers in datetime picker. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
For example, the timepicker shows 5 Σεπ 2015 - 10:12:26 π.μ. when the page is loaded. Making a date or time selection the timepicker changes it to 5 Σεπ 2015 - 3:00:00 AM.
Change History (5)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
The minor issue: Babel's formatted string uses μ.μ. for am/pm markers but the timepicker uses Μ.Μ.. It would be better to use same letter case for the markers.
Proposed changes in [620a48677/jomae.git].
comment:3 by , 9 years ago
| Milestone: | → 1.0.9 |
|---|
The change looks good to me. Should we include it in milestone:1.0.9 or wait for milestone:1.0.10?
One small thing, it looks like there is an unused statement period_names = get_period_names_jquery_ui(req) in chrome.py ([a01c2ce7/jomae.git#file2]).
comment:4 by , 9 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
Thanks for the reviewing. I push the changes with your suggestion soon.
comment:5 by , 9 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Good catch. The datetime picker has
amNamesandpmNamesoptions for localized am/pm markers. However, Trac doesn't use the options.Proposed changes in [a01c2ce70/jomae.git].