Edgewall Software

Opened 5 years ago

Closed 5 years ago

#12203 closed defect (fixed)

AM/PM is not translated by timepicker for Greek (Ελληνικά) locale

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Milestone: 1.0.9
Component: i18n Version:
Severity: normal Keywords: datetimepicker
Cc: Branch:
Release Notes:

Localize am/pm markers in datetime picker.

API Changes:
Internal Changes:


For example, the timepicker shows 5 Σεπ 2015 - 10:12:26 π.μ. when the page is loaded. Making a date or time selection the timepicker changes it to 5 Σεπ 2015 - 3:00:00 AM.

Attachments (0)

Change History (5)

comment:1 by Jun Omae, 5 years ago

Good catch. The datetime picker has amNames and pmNames options for localized am/pm markers. However, Trac doesn't use the options.

Proposed changes in [a01c2ce70/jomae.git].

comment:2 by Jun Omae, 5 years ago

The minor issue: Babel's formatted string uses μ.μ. for am/pm markers but the timepicker uses Μ.Μ.. It would be better to use same letter case for the markers.

Proposed changes in [620a48677/jomae.git].

comment:3 by Ryan J Ollos, 5 years ago

Milestone: 1.0.9

The change looks good to me. Should we include it in milestone:1.0.9 or wait for milestone:1.0.10?

One small thing, it looks like there is an unused statement period_names = get_period_names_jquery_ui(req) in chrome.py ([a01c2ce7/jomae.git#file2]).

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Jun Omae, 5 years ago

Owner: set to Jun Omae
Status: newassigned

Thanks for the reviewing. I push the changes with your suggestion soon.

comment:5 by Jun Omae, 5 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [14317] and merged to trunk in [14318].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.