KeyError: 'cnum'

[Ryan J Ollos]

Another traceback that was found in the logs:

2015-09-03 02:47:34,418 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "build/bdist.linux-i686/egg/trac/web/main.py", line 551, in _dispatch_request
    dispatcher.dispatch(req)
  File "build/bdist.linux-i686/egg/trac/web/main.py", line 244, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.linux-i686/egg/trac/ticket/web_ui.py", line 182, in process_request
    return self._process_ticket_request(req)
  File "build/bdist.linux-i686/egg/trac/ticket/web_ui.py", line 554, in _process_ticket_request
    cnum = int(req.args['cnum'])
KeyError: 'cnum'

[Jun Omae]

What about logging with the req object and its referrer for trouble shooting?

trac/web/api.py

@@ -358 +358 @@
         raise AttributeError(name)
 
     def __repr__(self):
-        path_info = self.environ.get('PATH_INFO', '')
-        return '<%s "%s %r">' % (self.__class__.__name__, self.method,
-                                 path_info)
+        uri = self.environ.get('PATH_INFO', '')
+        qs = self.query_string
+        if qs:
+            uri += '?' + qs
+        return '<%s "%s %r">' % (self.__class__.__name__, self.method, uri)
 
     # Public API
 

trac/web/main.py

@@ -581 +581 @@
 
 def send_internal_error(env, req, exc_info):
     if env:
-        env.log.error("Internal Server Error: %s",
+        env.log.error("Internal Server Error: %r, referrer %r%s",
+                      req, req.environ.get('HTTP_REFERER'),
                       exception_to_unicode(exc_info[1], traceback=True))
     message = exception_to_unicode(exc_info[1])
     traceback = get_last_traceback()

After the patch:

2015-09-04 13:18:26,942 Trac[main] ERROR: Internal Server Error: <RequestWithSession "GET '/ticket/1?action=comment-diff'">, referrer None
Traceback (most recent call last):
  File "/src/tracdev/git/trac/web/main.py", line 554, in _dispatch_request
    dispatcher.dispatch(req)
  File "/src/tracdev/git/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/src/tracdev/git/trac/ticket/web_ui.py", line 182, in process_request
    return self._process_ticket_request(req)
  File "/src/tracdev/git/trac/ticket/web_ui.py", line 554, in _process_ticket_request
    cnum = int(req.args['cnum'])
KeyError: 'cnum'

[Ryan J Ollos]

That looks useful. I'll test out the patch. Thanks!

[Ryan J Ollos]

comment:1 change committed to 1.0-stable in [14294], merged to trunk in [14295].

Proposed changes in log:rjollos.git:t12198_invalid_cnum.