CommitTicketReference macro with no arguments crashes

[Jun Omae]

When [[CommitTicketReference]] is invoked as wiki macro, it leads AttributeError.

2015-08-26 14:45:24,833 Trac[formatter] DEBUG: Executing Wiki macro CommitTicketReference by provider <tracopt.ticket.commit_updater
.CommitTicketReferenceMacro object at 0x7f255426ead0>
2015-08-26 14:45:24,860 Trac[formatter] ERROR: Macro CommitTicketReference(None) failed:
Traceback (most recent call last):
  File "/venv/trac/1.0.8/lib/python2.5/site-packages/trac/wiki/formatter.py", line 789, in _macro_formatter
    return macro.ensure_inline(macro.process(args))
  File "/venv/trac/1.0.8/lib/python2.5/site-packages/trac/wiki/formatter.py", line 358, in process
    text = self.processor(text)
  File "/venv/trac/1.0.8/lib/python2.5/site-packages/trac/wiki/formatter.py", line 342, in _macro_processor
    text, self.args)
  File "/venv/trac/1.0.8/lib/python2.5/site-packages/tracopt/ticket/commit_updater.py", line 301, in expand_macro
    reponame = args.get('repository') or ''
AttributeError: 'NoneType' object has no attribute 'get'

tracopt/ticket/commit_updater.py

@@ -297 +297 @@
      - `revision`: the revision of the desired changeset
     """)
 
-    def expand_macro(self, formatter, name, content, args={}):
+    def expand_macro(self, formatter, name, content, args=None):
+        args = args or {}
         reponame = args.get('repository') or ''
         rev = args.get('revision')
         repos = RepositoryManager(self.env).get_repository(reponame)

[Ryan J Ollos]

Moving tickets that appear to be uncompleted for milestone:1.0.9. Please move back to milestone:1.0.9 if the ticket can be completed by 2015-09-07 18:00 UTC.

[Ryan J Ollos]

I'll add a test and commit the change.

[Ryan J Ollos]

Committed to 1.0-stable in [14449], merged to trunk in [14450].