Possible mistyped processor on TracDownload

[figaro]

At the bottom of page TracDownload the following is shown: Error: Failed to load processor apache No macro or processor named 'apache' found

This is possibly the result of a mistyped processor on that page.

[figaro]

Updated description and summary.

[Ryan J Ollos]

This is due to a Pygments installation issue that I've noted in our internal issue tracker. However, the issue is also present on TracModWSGI which gets distributed with Trac so the errors will be seen whenever Pygments is not installed. We should probably add a known mimetype for the ​ApacheConf Lexer:

trac/mimeview/api.py

@@ -304 +304 @@
     'text/xml':                'xml',
 
     # see also TEXT_X_TYPES below
+    'text/x-apacheconf':       'apache',
     'text/x-csrc':             'c xs',
     'text/x-chdr':             'h',
     'text/x-c++src':           'cc CC cpp C c++ C++',

[Jun Omae]

That change looks good to me. We could add check of invalid wiki processors to checkwiki.py.

contrib/checkwiki.py

@@ -51 +51 @@
                 self.__marks.append((fullmatch.start(0), fullmatch.end(0)))
         return rv
 
+    def handle_code_block(self, line, startmatch=None):
+        prev_processor = getattr(self, 'code_processor', None)
+        try:
+            return self.__super.handle_code_block(line, startmatch)
+        finally:
+            processor = self.code_processor
+            if startmatch and processor and processor != prev_processor and \
+                    processor.error:
+                self.__marks.append((startmatch.start(0), startmatch.end(0)))
+
     def format(self, text, out=None):
         return self.__super.format(SourceWrapper(self, text), out)
 
@@ -160 +170 @@
     if options.download:
         download_default_pages(args, options.prefix)
 
-    env = EnvironmentStub()
+    env = EnvironmentStub(disable=['trac.mimeview.pygments.*'])
     load_components(env)
     with env.db_transaction:
         for name in names:

The same issue raises on #!pycon in TracPlugins page.

$ python contrib/checkwiki.py | grep '#!' | sed -e 's/^\([^:]*\):[0-9]*:\(.*\)$/\1:\2/' | sort | uniq -c
      3 TracCgi:{{{#!apache
      1 TracFineGrainedPermissions:{{{#!apache
      3 TracInstall:{{{#!apache
      3 TracInterfaceCustomization:{{{#!apache
     18 TracModPython:{{{#!apache
     15 TracModWSGI:{{{#!apache
      4 TracPlugins:{{{#!apache
      1 TracPlugins:{{{#!pycon
      1 TracStandalone:{{{#!apache

[Ryan J Ollos]

comment:2 change committed to 1.0-stable in [14277], merged to trunk in [14278].

The change in comment:3 seems like a good idea.