Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

#12142 closed defect (fixed)

EnvironmentStub appears on Trac plugin admin panel

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.9
Component: admin/web Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Don't show EnvironmentStub on the plugin admin page.

API Changes:

Description

trac.test.EnvironmentStub appears on the plugin admin page.

The issue is resolved with the following patch, but this might be a semantic abuse of abstract.

  • trac/test.py

    diff --git a/trac/test.py b/trac/test.py
    index 63051d1..c2e402b 100755
    a b class EnvironmentStub(Environment):  
    231231
    232232    global_databasemanager = None
    233233    required = False
     234    abstract = True
    234235
    235236    def __init__(self, default_data=False, enable=None, disable=None,
    236237                 path=None, destroying=False):

I have vague memories of having dealt with this previously, but perhaps I'm confusing the situation with something else.

Attachments (0)

Change History (2)

comment:1 by Ryan J Ollos, 4 years ago

Milestone: 1.0.9
Owner: set to Ryan J Ollos
Release Notes: modified (diff)
Status: newassigned

I don't see any issues with making a test Component abstract and not having it in the Component registry. Please let me know if you see any issues with this.

Proposed changes in log:rjollos.git:t12142.

comment:2 by Ryan J Ollos, 4 years ago

Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [14245], merged to trunk in [14246].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.