Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

#12108 closed defect (fixed)

SubversionRepository.get_path_url() should encode meta characters and unicode characters

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.7
Component: version control Version: 0.12-stable
Severity: normal Keywords: svn
Cc: Branch:
Release Notes:

SubversionRepository.get_path_url() encodes meta characters and unicode characters in the generated URL.

API Changes:
Internal Changes:

Description

SubversionRepository.get_path_url() generates URL for the given path and revision. The given path can include meta characters and unicode characters, e.g. #, %, ?.

However, the method returns generated URL without url-encoding. It should encode those characters in the URL.

>>> DbRepositoryProvider(env).modify_repository('svnrepos', {'url': 'http://localhost'})
>>> repos = env.get_repository('svnrepos')
>>> repos.get_path_url(u'tête/Résumé.txt', 29)
u'http://localhost/t\xeate/R\xe9sum\xe9.txt'
>>> repos.get_path_url(u'trunk/file#name.txt', 29)
u'http://localhost/trunk/file#name.txt'
>>> repos.get_path_url(u'trunk/file%name.txt', 29)
u'http://localhost/trunk/file%name.txt'

Attachments (0)

Change History (2)

comment:1 by Jun Omae, 6 years ago

Owner: set to Jun Omae
Status: newassigned

Proposed changes in [e1ba288b9/jomae.git].

comment:2 by Jun Omae, 6 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [14115] and merged to trunk in [14116].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.