Add get_table_names method to DatabaseManager

[Ryan J Ollos]

It would be useful to have a get_table_names method on DatabaseManager. The method would just be a helper that calls get_table_names on the ConnectionBase class, similar to how DatabaseManager.reset_tables directly calls reset_tables on the ConnectionBase class: tags/trac-1.1.5/trac/db/api.py@:393-394#L386​.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12105_get_table_names.

[Jun Omae]

I think we should compare table names of default_schema and the result of DatabaseManager.get_table_names(), e.g. for case get_table_names() returns unnecessary names.

trac/db/tests/api.py

@@ -520 +520 @@
 
     def test_get_table_names(self):
         """Get table name for the default database."""
-        table_names = self.dbm.get_table_names()
-        for table in default_schema:
-            self.assertIn(table.name, table_names)
+        self.assertEqual(sorted(table.name for table in default_schema),
+                         sorted(self.dbm.get_table_names()))
 
     def test_set_default_database_version(self):
         """Set database version for the default entry named

[Ryan J Ollos]

Thanks for reviewing. Committed to trunk in [14114].