Notifications panel in preferences crashes

[Jun Omae]

I found a fatal error on notifications panel in preferences with Trac 1.1.5dev r14047.

Traceback (most recent call last):
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/web/main.py", line 571, in _dispatch_request
    dispatcher.dispatch(req)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/web/main.py", line 230, in dispatch
    resp = chosen_handler.process_request(req)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/prefs/web_ui.py", line 98, in process_request
    panel_id)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/notification/prefs.py", line 88, in render_preference_panel
    defaults.extend(i.default_subscriptions())
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/notification/api.py", line 346, in default_subscriptions
    for d in self.subscriber_defaults[klass]:
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/cache.py", line 73, in __get__
    return CacheManager(instance.env).get(id, self.retriever, instance)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/cache.py", line 242, in get
    data = retriever(instance)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/notification/api.py", line 343, in subscriber_defaults
    return parse_subscriber_config(rawsubscriptions)
  File "/home/jun66j5/src/tracdev/svn/trunk/trac/notification/api.py", line 177, in parse_subscriber_config
    if attribute not in known_attrs.keys or \
TypeError: argument of type 'builtin_function_or_method' is not iterable

[notification-subscriber] section is configured with the following:

[notification-subscriber]
always_email = AlwaysEmailSubscriber
always_email.format = text/html
always_notify_cc = CarbonCopySubscriber
always_notify_owner = TicketOwnerSubscriber

Ad hoc patch. We should add unit tests for parse_subscriber_config in trac.notification.api.

trac/notification/api.py

@@ -174 +174 @@
             byname[name]['class'] = value.strip()
         else:
             attribute = parts[1]
-            if attribute not in known_attrs.keys or \
+            if attribute not in known_attrs or \
                     isinstance(known_attrs[attribute], str):
                 byname[name][attribute] = value
             elif isinstance(known_attrs[attribute], int):

[Jun Omae]

Proposed changes in jomae.git@t12055.

[Jun Omae]

Committed in [14054:14055].