About page doesn't use access key as documented

[Ryan J Ollos]

TracAccessibility claims that the platform-appropriate keyboard combination + 9 will navigate to the about page, however that is not the case.

Also the 0 access key doesn't navigate to TracAccessibility, as documented.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12045.

Is an empty link element the best way to add a shortcut to TracAccessibility?

[Ryan J Ollos]

Replying to rjollos:

Is an empty link element the best way to add a shortcut to TracAccessibility?

Or should a link element be used?

Looks like accesskey is not supported for link elements in HTML4.

[Jun Omae]

If an empty link has padding with background styles, the link would be visible. It would be good to make the link invisible using display:none.

The accesskey is introduced in [425] and #171. The TracAccessibility link is wrapped by <li> element with display:none. See trunk/templates/header.cs@425#L74​. The link is removed in [1586] for unexplained reasons.

Also, we should render it if a user has the permissions.

-    <a href="${href.wiki('TracAccessibility')}" accesskey="0"></a>
+    <a py:if="'WIKI_VIEW' in perm('wiki', 'TracAccessibility')"
+       href="${href.wiki('TracAccessibility')}" accesskey="0" style="display:none"></a>

However, the link would be only focused by the accesskey in Internet Explorer. It requires Enter key to visit the linked page. Therefore, it doesn't work on IE if the link is invisible.

Another considering, we could remove accesskey 0 from TracAccessibility page. I don't think the accesskey 0 is needed.

[Ryan J Ollos]

Replying to jomae:

Another considering, we could remove accesskey 0 from TracAccessibility page. I don't think the accesskey 0 is needed.

That seems like the best option. TracAccessibility hasn't received much attention over the years and I think we could do a much better job if we spent time to implement more extensive keyboard shortcuts. I would like to do that eventually since I use keyboard shortcuts extensively in other applications such as Gmail. I haven't taken the time to study how this could be implemented though; maybe using a JavaScript library.

Committed to 1.0-stable in [14012], merged to trunk in [14013]. Documentation updated in TracAccessibility@.