Opened 9 years ago
Last modified 9 years ago
#12028 closed defect
[changeset:13888] is plain wrong - `parse_connection_uri` may trim `params` for the returned dictionary — at Initial Version
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.5 |
| Component: | database backend | Version: | 1.1.4 |
| Severity: | normal | Keywords: | postgresql |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
13888 is assuming that the dictionary returned by parse_connection_uri contains a params key, replacing the call .setdefault('params', {}) by ['params'].
However, parse_connection_uri trims the returned dictionary from the key-value pairs for values coercible to False. The default value of params (= {}) is coercible to False.
Either parse_connection_uri should not trim such values, either 13888 should be reverted.
This currently makes the backup command unusable under some conditions.
Note:
See TracTickets
for help on using tickets.
