non-portable use of strftime

[anonymous]

In several places, function strftime is used with the %F and %R format code. However, those two format codes are non-standard and thus to be considered implementation-dependent. In particular, both codes are not supported on the Win32 platform. It might be better to replace the hard-coded string literals '%F' and '%R' with configuration variables that could be used to customize the date and time format.

[daniel]

Indeed, the time formatting is inconsistent and hardcoded. While once solution is certainly to offer a customizable time format string (or similar), that would require more settings/configuring.

I think it's better to go the the system's locale, since that's (on UNIX at least) set simply by environment variables. So if you wish to run Trac using a different locale than the system-default, just change the environment for the server/cgi.

If I'm dead wrong here, we can change it later. It'll still be better than the buggy way we do it now. :-)

Thank you for the report, it was very helpful.

/d

[daniel]

In [241], I changed all the %F and %R to locale-specific (and portable) %x, %X and %c .