incorrect milestone pre-selected in change properties dropdown menu when empty

[ebouaziz@…]

following #11018

Since Trac uses the null value to represent empty properties in the database, when the milestone of a ticket is empty, the milestone dropdown menu in the change properties area has the default milestone pre-selected instead of the empty one.

A visible effect is that if you simply want to add a comment on such a ticket, the milestone will be changed from empty to the default milestone, which is not empty in our case.

This does not happen on tickets that have an empty milestone represented as an empty string.

It also happens with the version property.

This happens because of the get_value_or_default() function in trac/ticket/model.py:

I believe the line:

    return value if value is not empty else self.get_default(name)

should be:

    return value if value is not empty else ''

This function is called only in trac/ticket/templates/ticket.html to fill the ticket's fields.

[Ryan J Ollos]

I can reproduce the issue on 1.0-stable as well, I think it's not related to #11018.

Proposed fix:

trac/ticket/templates/ticket.html

@@ -226 +226 @@
                     py:if="can_modify or can_create"
                     py:with="fullrow = len(row) == 1">
                   <py:for each="idx, field in enumerate(row)"
-                          py:with="value = ticket.get_value_or_default(field.name)">
+                          py:with="value = ticket[field.name] if ticket.exists
+                                                              else ticket.get_value_or_default(field.name)">
                     <th class="col${idx + 1}" py:if="idx == 0 or not fullrow">
                       <label for="field-${field.name}" py:if="field"
                              py:strip="field.type == 'radio'" i18n:msg="field">${

[ebouaziz@…]

yes, it's probably better this way!

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11996.

[Ryan J Ollos]

Committed to 1.0-stable in [13944], merged to trunk in [13945:13946]