Edgewall Software

Opened 8 years ago

Closed 7 years ago

#11990 closed defect (fixed)

Hide subscription rules preferences if no subscription rules available

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.2
Component: notification Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Subscription rules preferences are hidden if no rules are available.

API Changes:
Internal Changes:


It was discussed in comment:44:ticket:4056, that the Subscription rules preferences be hidden if no rules are available, an example of which is shown in the following screen capture:

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 7 years ago

Milestone: undecidednext-dev-1.1.x

comment:2 by Ryan J Ollos, 7 years ago

It looks like the following patch is sufficient to fix the issue:

  • trac/notification/templates/prefs_notification.html

    diff --git a/trac/notification/templates/prefs_notification.html b/trac/notification/templates/prefs_notification.html
    index fc93a07..3a8a94d 100644
    a b  
    125125            Configure the format of your ${distributor} notifications.
    126126          </p>
    127127        </div>
    128         <div class="field">
     128        <div class="field" py:if="data['subscribers']">
    129129          <label>Subscription rules:</label>
    130130          <table class="subscription-rules" summary="Subscription rules">
    131131            <tbody class="rules rules-$distributor">

comment:3 by Peter Suter, 7 years ago

Looks good to me, thanks.

comment:4 by Ryan J Ollos, 7 years ago

Milestone: next-dev-1.1.x1.2
Owner: set to Ryan J Ollos
Status: newassigned

comment:5 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to trunk in [14194].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.