Context Navigation

Modify ↓

#11979 closed defect (fixed)

Reported by:	Jun Omae	Owned by:	Jun Omae
Priority:	normal	Milestone:	1.0.6
Component:	version control/log view	Version:	0.12-stable
Severity:	minor	Keywords:
Cc:		Branch:
Release Notes:	Fix off-by-one error in `limit` parameter of log view when no history remaining.
API Changes:
Internal Changes:

log:?rev=10 shows 10 commits but log:?rev=10&limit=10 shows 9 commits. The limit parameter has off-by-one error.

diff --git a/trac/versioncontrol/web_ui/log.py b/trac/versioncontrol/web_ui/log.py
index 9e4d3cc..ed4e910 100644

                class LogModule(Component):
                            '%(rev)s)', path=next_path,
                            rev=display_rev(next_rev)))
             # only show fully 'limit' results, use `change == None` as a marker
+            info[-1]['change'] = None
+            if count > limit:
+                info[-1]['change'] = None
         revisions = [i['rev'] for i in info]
         changes = get_changes(repos, revisions, self.log)

I'll push it with unit tests later.

Owner:	set to Jun Omae
Status:	new → assigned

The below patch is incomplete. Reworked and proposed changes in jomae.git@t11979.

Committed in [13917] and merged to trunk in [13918].

Change Properties

Summary:
Description:	log:?rev=10 shows 10 commits but log:?rev=10&limit=10 shows 9 commits. The `limit` parameter has off-by-one error. {{{#!diff diff --git a/trac/versioncontrol/web_ui/log.py b/trac/versioncontrol/web_ui/log.py index 9e4d3cc..ed4e910 100644 --- a/trac/versioncontrol/web_ui/log.py +++ b/trac/versioncontrol/web_ui/log.py @@ -256,7 +256,8 @@ class LogModule(Component): '%(rev)s)', path=next_path, rev=display_rev(next_rev))) # only show fully 'limit' results, use `change == None` as a marker - info[-1]['change'] = None + if count > limit: + info[-1]['change'] = None revisions = [i['rev'] for i in info] changes = get_changes(repos, revisions, self.log) }}} I'll push it with unit tests later. You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:	Fix off-by-one error in `limit` parameter of log view when no history remaining.
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Jun Omae.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Jun Omae to the specified user.

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.