Edgewall Software
Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11930 closed defect (fixed)

Workflow action names are not shown

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: high Milestone: 1.0.4
Component: general Version: 1.0.3
Severity: major Keywords: workflow
Cc:
Release Notes:

Fixed workflow action labels are not displayed unless name attribute is explicitly defined (regression in [13420]).

API Changes:

Description (last modified by Ryan J Ollos)

On a clean install of Trac 1.0.3, the workflow controls show the following:

This is a major regression that I introduced in [13420], and managed to overlook in further development and while testing the release. It likely warrants immediate release of Trac 1.0.4 with a fix. Please let me know thoughts on that. The issue is not present in Trac 1.1.4.

  • trac/ticket/default_workflow.py

    diff --git a/trac/ticket/default_workflow.py b/trac/ticket/default_workflow.py
    index a9b614d..57c1654 100644
    a b def parse_workflow_config(rawactions):  
    7070                actions[name][attribute] = to_list(value)
    7171            else:
    7272                actions[name][attribute] = value
     73    for name, attrs in actions.iteritems():
     74        if not attrs.get('name'):
     75            attrs['name'] = name
    7376    return actions

Workaround is to add a name attribute to every workflow action.

Attachments (1)

WorkflowControls.png (23.2 KB ) - added by Ryan J Ollos 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by Ryan J Ollos

Attachment: WorkflowControls.png added

comment:1 in reply to:  description ; Changed 4 years ago by Peter Suter

Replying to rjollos:

This is a major regression that I introduced in [13420], and managed to overlook in further development and while testing the release. It likely warrants immediate release of Trac 1.0.4 with a fix. Please let me know thoughts on that.

How unfortunate. Yeah, a quick 1.0.4 release may be a good idea.

comment:2 Changed 4 years ago by Ryan J Ollos

Description: modified (diff)

comment:3 in reply to:  1 Changed 4 years ago by Ryan J Ollos

Replying to psuter:

How unfortunate. Yeah, a quick 1.0.4 release may be a good idea.

Thanks for the feedback. I'll commit the fix soon with regression tests. Provided nothing surfaces on the mailing list that would make us think to proceed differently, then I'll prepare the release tomorrow evening.

comment:4 Changed 4 years ago by Ryan J Ollos

Release Notes: modified (diff)
Status: newassigned

Regression fixed in [13692], record-only merge in [13693]. Regression tests are forthcoming.

comment:5 Changed 4 years ago by Ryan J Ollos

Description: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Regression test added in [13714], merged to trunk in [13715].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.