#11930 closed defect (fixed)
Workflow action names are not shown
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0.4 |
| Component: | general | Version: | 1.0.3 |
| Severity: | major | Keywords: | workflow |
| Cc: | Branch: | ||
| Release Notes: |
Fixed workflow action labels are not displayed unless |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
On a clean install of Trac 1.0.3, the workflow controls show the following:
This is a major regression that I introduced in [13420], and managed to overlook in further development and while testing the release. It likely warrants immediate release of Trac 1.0.4 with a fix. Please let me know thoughts on that. The issue is not present in Trac 1.1.4.
-
trac/ticket/default_workflow.py
diff --git a/trac/ticket/default_workflow.py b/trac/ticket/default_workflow.py index a9b614d..57c1654 100644
a b def parse_workflow_config(rawactions): 70 70 actions[name][attribute] = to_list(value) 71 71 else: 72 72 actions[name][attribute] = value 73 for name, attrs in actions.iteritems(): 74 if not attrs.get('name'): 75 attrs['name'] = name 73 76 return actions
Workaround is to add a name attribute to every workflow action.
Attachments (1)
Change History (6)
by , 10 years ago
| Attachment: | WorkflowControls.png added |
|---|
follow-up: 3 comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 10 years ago
Replying to psuter:
How unfortunate. Yeah, a quick 1.0.4 release may be a good idea.
Thanks for the feedback. I'll commit the fix soon with regression tests. Provided nothing surfaces on the mailing list that would make us think to proceed differently, then I'll prepare the release tomorrow evening.
comment:4 by , 10 years ago
| Release Notes: | modified (diff) |
|---|---|
| Status: | new → assigned |
Replying to rjollos:
How unfortunate. Yeah, a quick 1.0.4 release may be a good idea.