Missing X-Trac-Ticket-URL header in ticket notification mail since 1.1.3

[Jun Omae]

We should add header like this.

X-Trac-Ticket-URL: http://trac-hacks.org/ticket/12158#comment:4

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Trac-Realm: ticket
From: "My Project" <trac@localhost>
X-Trac-Version: 1.1.3
Precedence: bulk
Auto-Submitted: auto-generated
X-Mailer: Trac 1.1.3, by Edgewall Software
To: undisclosed-recipients: ;
References: <011.5820a89cc2c970d854f42757ba2afba4@localhost>
X-Trac-Project: My Project
In-Reply-To: <011.5820a89cc2c970d854f42757ba2afba4@localhost>
Date: Thu, 22 Jan 2015 04:58:51 -0000
Reply-To: trac@localhost
Message-ID: <026.95f8819ec9a6fc74629637032ed18e26@localhost>
X-URL: 
Subject: Re: [My Project] #1: test

#1: test
...

See ​th:#12158

[Peter Suter]

Makes sense. Previously​ we also had X-Trac-Ticket-ID apparently. TicketFormatter already implements a ticket specific IEmailDecorator, so we could add it there:

trac/ticket/notification.py

@@ -223 +223 @@
             notify.ticket = event.target
             summary = event.target['summary']
             subject = notify.format_subj(summary, event.category == 'created')
+
+            id = str(event.target.id)
+            link = self.env.abs_href.ticket(id)
+            set_header(message, 'X-Trac-Ticket-ID', id, charset)
+            set_header(message, 'X-Trac-Ticket-URL', link, charset)
         set_header(message, 'Subject', subject, charset)

I'm not sure how best to get the cnum for appending #comment:4​ to the link.

[Jun Omae]

I'm not sure how best to get the cnum for appending #comment:4​ to the link.

Proposed changes in jomae.git@t11926, which added Ticket.get_comment_number(cdate) for it.

[Peter Suter]

Looks good to me. Thanks.

[Jun Omae]

Thanks for the reviewing. Commtted in [13690-13691].