Edgewall Software

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11850 closed defect (fixed)

Permission and new state for _reset action can't be customized — at Version 3

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.3
Component: ticket system Version:
Severity: normal Keywords: workflow
Cc: Branch:
Release Notes:

Attributes of the special _reset action can be customized in the [ticket-workflow] section of trac.ini.

API Changes:

The get_all_actions method of the ConfigurableTicketWorkflow class returns a dictionary of the actions defined in the configuration as well as implicit actions such as the default _reset action.

Internal Changes:

Description

If a _reset action is provided through the [ticket-workflow], the required permissions will still be restricted to TICKET_ADMIN and the new state will always be new. In the following example the ticket would be reset to new rather than needs_triage and only a user with TICKET_ADMIN would be able to reset the ticket: 

_reset = -> needs_triage
_reset.operations = reset_workflow
_reset.name = reset
_reset.permissions =

Further, the hint in the workflow dialog will be incorrect:

The problematic code is:

The default _reset action and the reset_workflow operation were added in #5307.

Change History (4)

by Ryan J Ollos, 9 years ago

Attachment: InvalidState.png​ added

comment:1 by Ryan J Ollos, 9 years ago

Proposed changes in log:rjollos.git:t11850-custom-reset-action.1.

Additions to workflow documentation in TracWorkflow@62.

comment:2 by Ryan J Ollos, 9 years ago

Status: new → assigned

comment:3 by Ryan J Ollos, 9 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 1.0-stable in [13420], merged to trunk in [13421:13422].

Last edited 9 years ago by Ryan J Ollos (previous) (diff)
Note: See TracTickets for help on using tickets.