Edgewall Software
Modify

Opened 10 years ago

Closed 10 years ago

#11844 closed defect (worksforme)

WikiFormatting for Image should include image dimensions

Reported by: vlastimil.zima@… Owned by:
Priority: normal Milestone:
Component: web frontend Version: 1.0.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When an image is inserted in Trac using [[Image()]] macro, the HTML output should contain width and height attributes.

Currently these attributes are missing which causes anchors to be useless on pages with images especially when there is several of big ones. The browser usually doesn't compute the position of the anchor correctly and so it doesn't perform scrolling as required, but less.

Experienced in Firefox 33 using comment links in ticket with large number of images in comments.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 10 years ago

Milestone: next-stable-1.0.x

Looks like you are probably correct about this: SO:1247693/121694. I'll do some more research. Would you like to provide a patch (PatchWelcome)?

comment:2 by Peter Suter, 10 years ago

You can specify width and height parameters in the [[Image()]] macro, e.g. the image trac_logo_mini.png has width and height attributes in the HTML output from these macro parameters: [[Image(htdocs:../common/trac_logo_mini.png, width=107, height=30)]]

To add these automatically Trac would have to know how to parse various image file formats. It's not obvious to me that the benefits of that would outweigh the downsides.

comment:3 by Ryan J Ollos, 10 years ago

Milestone: next-stable-1.0.x
Resolution: worksforme
Status: newclosed

I think the argument in comment:2 is enough to close this as worksforme.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.