Margin above Description text area on Basic Settings page

[Ryan J Ollos]

The Description has a margin between the label and textarea on Firefox (test with version 33 on Ubuntu and 33.1 on Windows), but not on Chrome (version 38 on Ubuntu and Windows).

Firefox:

Chrome

Also the margin between Description and Default handler is different.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

It seems the spacing between Description and the textarea can be fixed by removing the br:

trac/admin/templates/admin_basics.html

@@ -39 +39 @@
             </label>
           </div>
           <div class="field">
-            <label>${_("Description:")}<br />
+            <label>${_("Description:")}
               <textarea name="descr" class="trac-resizable" rows="3" cols="50">
 ${project.descr}</textarea>
             </label>

[Ryan J Ollos]

Replying to Ryan J Ollos:

Also the margin between Description and Default handler is different.

It seems to be somehow due to the rule form.mod .field label { padding-left: .2em }​.

[Jun Omae]

Replying to Ryan J Ollos:

It seems the spacing between Description and the textarea can be fixed by removing the br:

The following would be resulted if [trac] resizable_textareas is disabled:

Also, the original issue is occurred on 1.2-stable with Firefox 54 but it doesn't on 1.0-stable.

[Jun Omae]

I consider Firefox renders a newline for br element if block element is after br element. Another workaround is to use display: inline-table rather than display: table.

trac/htdocs/css/trac.css

@@ -678 +678 @@
 .wikitoolbar a#img { background-position: 0 -128px }
 
 /* Textarea resizer */
-div.trac-resizable { display: table; width: 100% }
+div.trac-resizable { display: inline-table; width: 100% }
 div.trac-resizable > div { display: table-cell }
 div.trac-resizable textarea { display: block; margin-bottom: 0 }
 div.trac-grip {

[Ryan J Ollos]

Thanks, that works great and fixes both problems. Tested with FF 54, Chrome 59, Opera 46 and Safari 10 on OSX 10.12.6.

Committed to 1.2-stable in r16148, merged to trunk in r16149.

I'll rebase #11112 and re-evaluate those changes in light of this change.