interactive trac-admin crashes on unclosed quotes

[anonymous]

When used interactively, trac-admin does not handle the exception raised by shlex on an unclosed quote. Instead trac-admin crashes to the command line with a traceback. Presumably other exceptions raised by shlex are unhandled as well. I am using python 2.3 but I assume shlex still raises the exception in 2.4.

myserver$ trac-admin /var/trac/myproject
Welcome to trac-admin 0.8
Interactive Trac adminstration console.
Copyright (c) 2004 Edgewall Software

Type:  '?' or 'help' for help on commands.

Trac [/var/trac/myproject]> component list'
Traceback (most recent call last):
  File "/usr/bin/trac-admin", line 999, in ?
    main()
  File "/usr/bin/trac-admin", line 991, in main
    tracadm.run()
  File "/usr/bin/trac-admin", line 75, in run
    self.cmdloop()
  File "/usr/lib/python2.3/cmd.py", line 133, in cmdloop
    stop = self.onecmd(line)
  File "/usr/lib/python2.3/cmd.py", line 210, in onecmd
    return func(arg)
  File "/usr/bin/trac-admin", line 308, in do_component
    arg = self.arg_tokenize(line)
  File "/usr/bin/trac-admin", line 135, in arg_tokenize
    toks = shlex.split(argstr)
  File "/usr/lib/python2.3/shlex.py", line 279, in split
    return list(lex)
  File "/usr/lib/python2.3/shlex.py", line 269, in next
    token = self.get_token()
  File "/usr/lib/python2.3/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/usr/lib/python2.3/shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"
ValueError: No closing quotation
myserver$

[felix@…]

I can confirm seeing this on 0.8 Win2000

[Matthew Good]

This was fixed in r2271.