Remove deprecated functionality and API functions and methods

[Ryan J Ollos]

For milestone:1.1.2 deprecated code was removed in #11605 and #11494. For milestone:1.1.3 the changes will be captured in this ticket (along with #11703 and #11539).

[Ryan J Ollos]

Removal of InterTrac compat property in log:rjollos.git:t11823.

[Ryan J Ollos]

Replying to rjollos:

Removal of InterTrac compat property in log:rjollos.git:t11823.

Documentation updated in 1.1/InterTrac@2.

[Ryan J Ollos]

Change from comment:1 committed in [13314].

[Ryan J Ollos]

Spotted a comment about moving WikiMacroBase: tags/trac-1.0.2/trac/ticket/query.py@:50#L29​. Opinions on whether it should be moved?

[Ryan J Ollos]

It looks like support for legacy WebAdmin panels can be removed:

• tags/trac-1.0.2/trac/admin/templates/admin_legacy.html​
• tags/trac-1.0.2/trac/admin/web_ui.py@:118,122-134#L104​.

[Ryan J Ollos]

Replying to rjollos:

It looks like support for legacy WebAdmin panels can be removed:

• tags/trac-1.0.2/trac/admin/templates/admin_legacy.html​
• tags/trac-1.0.2/trac/admin/web_ui.py@:118,122-134#L104​.

Removed in [13438].

Refactoring in [13439].

[Ryan J Ollos]

TODO Consider resolving #9612 in this release.

[Ryan J Ollos]

We could drop support for 0.10 ITimelineEventProviders:

trac/timeline/web_ui.py

@@ -193 +193 @@
             try:
                 for event in provider.get_timeline_events(req, start, stop,
                                                           filters) or []:
-                    # Check for 0.10 events
-                    author = (event[2 if len(event) < 6 else 4] or '').lower()
+                    author = (event[2] or '').lower()
                     if (not include or author in include) \
                        and not author in exclude:
                         events.append(self._event_data(provider, event))
@@ -369 +368 @@
     def _event_data(self, provider, event):
         """Compose the timeline event date from the event tuple and prepared
         provider methods"""
-        if len(event) == 6:  # 0.10 events
-            kind, url, title, date, author, markup = event
-            data = {'url': url, 'title': title, 'description': markup}
-            render = lambda field, context: data.get(field)
-        else:  # 0.11 events
-            if len(event) == 5:  # with special provider
-                kind, date, author, data, provider = event
-            else:
-                kind, date, author, data = event
-            render = lambda field, context: \
-                     provider.render_timeline_event(context, field, event)
+        if len(event) == 5:  # with special provider
+            kind, date, author, data, provider = event
+        else:
+            kind, date, author, data = event
+        render = lambda field, context: \
+                 provider.render_timeline_event(context, field, event)
         if not isinstance(date, datetime):
             date = datetime.fromtimestamp(date, utc)
         dateuid = to_utimestamp(date)

[Ryan J Ollos]

Patch from comment:9 committed in [13466].

[Ryan J Ollos]

Replying to rjollos:

TODO Consider resolving #9612 in this release.

In comment:8:ticket:9612 I've proposed adding some notices to the code, and scheduling the parameters for removal in milestone:1.3.1.

[Ryan J Ollos]

Some additional changes for the timeline module:

• Remove documentation: trunk/trac/timeline/api.py@12501:46,56-59#L39​
• The API documentation specifies that get_timeline_events returns a datetime object​ so following appears to be no longer needed: trunk/trac/timeline/web_ui.py@13466:377-378#L368​.

[Ryan J Ollos]

Replying to rjollos:

Replying to rjollos:

It looks like support for legacy WebAdmin panels can be removed:

• tags/trac-1.0.2/trac/admin/templates/admin_legacy.html​
• tags/trac-1.0.2/trac/admin/web_ui.py@:118,122-134#L104​.

Removed in [13438].

Additional changes in [13573].

[Peter Suter]

Do you think we should add deprecation notices to source:trunk/trac/notification/compat.py for milestone 1.3.1 as well? Or what time-frame would be appropriate?

[Ryan J Ollos]

My feeling is that leaving a deprecation notice for one major release is good enough, and that appears to have been Christian's rule with deprecating code. The suggestion (wiki:TracDev/ApiChanges/1.1.1#OtherModificationsmadetothe1.0API) to remove the code early in the development release series seems good as well. I've been more conservative in removing old code, particularly for cases in which there wasn't a notice in the API docs.

[Peter Suter]

Thanks. Added deprecation notices in [13578].

[Ryan J Ollos]

Replying to rjollos:

Spotted a comment about moving WikiMacroBase: tags/trac-1.0.2/trac/ticket/query.py@:50#L29​.

I'm still not sure whether this class should be moved. Moved the TODO to the module in which the class is defined in [13588].

[Ryan J Ollos]

Replying to rjollos:

Some additional changes for the timeline module:

• Remove documentation: trunk/trac/timeline/api.py@12501:46,56-59#L39​
• The API documentation specifies that get_timeline_events returns a datetime object​ so following appears to be no longer needed: trunk/trac/timeline/web_ui.py@13466:377-378#L368​.

Fixed in [13589].

[Peter Suter]

Replying to psuter:

Thanks. Added deprecation notices in [13578].

I think I should also add a deprecation notice to get_ticket_notification_recipients​.

[Peter Suter]

Replying to psuter:

I think I should also add a deprecation notice to get_ticket_notification_recipients​.

Added in [13609].