Edgewall Software
Modify

Opened 15 years ago

Closed 14 years ago

Last modified 13 years ago

#1182 closed defect (fixed)

date format incorrect when delivering mail on non-english locales

Reported by: dlin@… Owned by: Christopher Lenz
Priority: normal Milestone: 0.8.2
Component: ticket system Version: 0.8
Severity: normal Keywords:
Cc: nepo@… Branch:
Release Notes:
API Changes:

Description

All date time strings seems work fine with my setting

SetEnv LC_TIME "zh_TW.utf8"

But, the e-mail's header, can't read zh_TW.utf8 formated date string. So, when I received e-mail from the trac, it is always be 1970/01/01 00:00 on linux machine.

I think it must keep general date time formating on e-mail's header.

Attachments (2)

trac-email-date.patch (777 bytes ) - added by Norbert Unterberg <nepo@…> 15 years ago.
Patch to resolve the wrong formatted Date header in notification e-mails
trac-email-date2.patch (942 bytes ) - added by Angel Marin <anmar@…> 14 years ago.
Python provides its own infrastructure for this (patch against r1509)

Download all attachments as: .zip

Change History (8)

comment:1 by Norbert Unterberg <nepo@…>, 15 years ago

Cc: nepo@… added

On a German windows server, the date is also wrong in notification e-mails. The date field in the e-mails is formatted according to the current language, but RFC822 requires that the date header is always in English.

by Norbert Unterberg <nepo@…>, 15 years ago

Attachment: trac-email-date.patch added

Patch to resolve the wrong formatted Date header in notification e-mails

comment:2 by Norbert Unterberg <nepo@…>, 15 years ago

Summary: date format incorrect when delivery mail on SetEnv LC_TIME "zh_TW.utf8"date format incorrect when delivering mail on non-english locales

I have just added a patch that solves the issue with the wrong formatted Date header in the notification e-mails — at least on my (German) system. The patch is based on the current trunk version (r1374).

I do not speak Python, so I just changed it the way I would in C, so feel free to modify it to make it the "python way".

comment:3 by Norbert Unterberg <nepo@…>, 14 years ago

Milestone: 0.9

I set the milestone to 0.9 because the bug is really anoying (to me), and I believe the fix is trivial. You may change it back to something else if you don't think so.

by Angel Marin <anmar@…>, 14 years ago

Attachment: trac-email-date2.patch added

Python provides its own infrastructure for this (patch against r1509)

comment:4 by Angel Marin <anmar@…>, 14 years ago

I've added a locale independent fix for this.

formatdate will generate a date string that conforms to RFC 2822 syntax.

comment:5 by Christopher Lenz, 14 years ago

Milestone: 0.90.8.2
Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

Nice patch, let's put this in 0.8.2.

comment:6 by Christopher Lenz, 14 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in [1512], ported to stable in [1513]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.