Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

#11819 closed defect (fixed)

Link attributes of navigation item are removed when label is defined in trac.ini

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.3
Component: general Version:
Severity: normal Keywords: navigation
Cc: Branch:
Release Notes:

The link attributes of a INavigationContributor are not removed when a label or href is redefined in trac.ini.

API Changes:
Internal Changes:

Description

When the label for a TracNavigation item is defined in the [mainnav] section of trac.ini, other attributes of the link such as target will be effectively stripped because the element is recreated: tags/trac-1.0.2/trac/web/chrome.py@:738#L716​.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 10 years ago

This issue was discovered while working on ​th:#12036.

comment:2 by Ryan J Ollos, 10 years ago

Milestone: next-stable-1.0.x → 1.0.3
Owner: set to Ryan J Ollos
Status: new → assigned

Proposed changes in log:rjollos.git:t11819.

comment:3 by Ryan J Ollos, 10 years ago

Revised changes with refactoring in log:rjollos.git:t11819.1.

comment:4 by Ryan J Ollos, 10 years ago

Release Notes: modified (diff)

comment:5 by Ryan J Ollos, 10 years ago

Resolution: → fixed
Status: assigned → closed

Committed to 1.0-stable in [13409], merged to trunk in [13410].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.