Opened 10 years ago
Closed 10 years ago
#11815 closed defect (fixed)
Test failures due to enabled unit test components in functional tests
| Reported by: | Peter Suter | Owned by: | Peter Suter |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.3 |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | functional tests |
| Cc: | Branch: | ||
| Release Notes: |
Fixed test execution failure when unit test components remained enabled in functional tests. |
||
| API Changes: |
|
||
| Internal Changes: | |||
Description
As discussed in comment:36:ticket:11605, the LegacyParticipant introduced in [12820] remains enabled in and breaks functional tests e.g. when running python -m trac.test (but not when running make test or python ./trac/test.py --skip-functional-tests followed by python trac/tests/functional/__init__.py -v).
By default all components in the trac packages are enabled, except trac.test.* (since #11421) but trac.tests.env.LegacyParticipant doesn't match that (test vs. tests).
Should we also exclude trac.tests.*? (We would need to explicitly enable some components in a few tests.)
Attachments (1)
Change History (4)
by , 10 years ago
| Attachment: | T11815-enable-trac-tests-components-explicitly.diff added |
|---|
comment:1 by , 10 years ago
comment:3 by , 10 years ago
| API Changes: | modified (diff) |
|---|---|
| Release Notes: | modified (diff) |
| Resolution: | → fixed |
| Status: | assigned → closed |
Committed with updated comment in [13316].
That patch looks good and works well for me. The only refinement I see is to update the comment above the code change in
trac/env.py.