Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

#11815 closed defect (fixed)

Test failures due to enabled unit test components in functional tests

Reported by: Peter Suter Owned by: Peter Suter
Priority: normal Milestone: 1.1.3
Component: general Version:
Severity: normal Keywords: functional tests
Cc: Branch:
Release Notes:

Fixed test execution failure when unit test components remained enabled in functional tests.

API Changes:

Environment.is_component_enabled returns None if passing a component in the trac.tests package.

Description

As discussed in comment:36:ticket:11605, the LegacyParticipant introduced in [12820] remains enabled in and breaks functional tests e.g. when running python -m trac.test (but not when running make test or python ./trac/test.py --skip-functional-tests followed by python trac/tests/functional/__init__.py -v).

By default all components in the trac packages are enabled, except trac.test.* (since #11421) but trac.tests.env.LegacyParticipant doesn't match that (test vs. tests).

Should we also exclude trac.tests.*? (We would need to explicitly enable some components in a few tests.)

Attachments (1)

T11815-enable-trac-tests-components-explicitly.diff (2.7 KB ) - added by Peter Suter 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by Ryan J Ollos, 5 years ago

That patch looks good and works well for me. The only refinement I see is to update the comment above the code change in trac/env.py.

comment:2 by Peter Suter, 5 years ago

Owner: set to Peter Suter
Status: newassigned

Thanks for checking!

comment:3 by Peter Suter, 5 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed with updated comment in [13316].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Peter Suter.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Peter Suter to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.