Edgewall Software
Modify ↓

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11804 closed enhancement (fixed)

Display hint in Add/Remove from Cc field when name and email not set in preferences

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.3
Component: ticket system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

For a user that doesn't have TICKET_EDIT_CC permission and hasn't set their email in Preferences, a hint is shown next to the Cc field with a link to Preferences. For a user that has set their email, the email address is wrapped in a label and can therefore toggle the add/remove checkbox.

API Changes:
Internal Changes:

Description

For an unauthenticated session in which the name and email have not been set in Preferences the following non-functional checkbox is shown:

Instead, we can show a hint:

The change was initially suggested in #10207.

Attachments (3)

cc-field.png​ (8.8 KB ) - added by Ryan J Ollos 11 years ago.
cc-field-new.png​ (10.4 KB ) - added by Ryan J Ollos 11 years ago.
WithMissingClass.png​ (17.5 KB ) - added by Ryan J Ollos 11 years ago.

Download all attachments as: .zip

Change History (10)

by Ryan J Ollos, 11 years ago

Attachment: cc-field.png​ added

by Ryan J Ollos, 11 years ago

Attachment: cc-field-new.png​ added

comment:1 by Ryan J Ollos, 11 years ago

Status: new → assigned

Proposed changes in log:rjollos.git:t11804.

by Ryan J Ollos, 11 years ago

Attachment: WithMissingClass.png​ added

comment:2 by Ryan J Ollos, 11 years ago

I considered lightening the Cc: label text to indicate that the field is disabled, similar to the properties with the missing class in the #ticket properties section. It doesn't look right to me, but let me know your thoughts.

comment:3 by Ryan J Ollos, 11 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 1.0-stable in [13237], merged to trunk in [13238].

comment:4 by Jun Omae, 11 years ago

The following one is extracted. I think that message has unnecessary bracket. 

msgid "[1:Set your email in [2:Preferences]]"
msgstr ""

It would be good to move i18n:msg to <span> element like this. 

-                                <i18n:msg py:when="'cc_entry' in field">
-                                  <span class="hint">Set your email in <a href="${href.prefs()}" class="trac-target-new">Preferences</a></span>
-                                </i18n:msg>
+                                <py:when test="'cc_entry' in field">
+                                  <span class="hint" i18n:msg="">Set your email in <a href="${href.prefs()}" class="trac-target-new">Preferences</a></span>
+                                </py:when>

comment:5 by Ryan J Ollos, 11 years ago

Thanks, fixed in [13239:13240].

comment:6 by Ryan J Ollos, 11 years ago

XHTML validation issue introduced in this ticket discussed and fixed in comment:14:ticket:10984 and later comments.

Last edited 11 years ago by Ryan J Ollos (previous) (diff)

comment:7 by Ryan J Ollos, 11 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.