Comment text box should span the width of the enclosing fieldset

[Ryan J Ollos]

I often find that the comment text box on the wiki edit page is too small and there is a lot of extra width within the enclosing fieldset. I propose to have the comment text box span the width of the fieldset.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11792. I'm proposing these changes for the trunk because ​TagsPlugin adds an input that will likely need to be re-positioned. I haven't been able to easily test the behavior since ​TagsPlugin doesn't work with the trunk at the moment (AttributeError: 'Environment' object has no attribute 'get_db_cnx').

I suspect the following rules are not useful at all, but I'm hesitant to remove them unless someone else can confirm, or I find time to do more testing:

#changeinfo { clear: both }
#changeinfo br { clear: left }
#changeinfo .options, #changeinfo .buttons { clear: left }

[Ryan J Ollos]

Additional changes in log:rjollos.git:t11792 result in the author field spanning the width of the form.

[Ryan J Ollos]

Thinking about how the layout changes in #11813 could affect plugins, I may target these changes to 1.1.3 rather than 1.0.3.

Some additional changes in log:rjollos.git:t11792-attachment-form would force the Description input on the attachment page to fill the width of the form.

[Jun Omae]

I'm trying rjollos.git:t11792-attachment-form rebased on trunk. Looks good to me.

Reading [1909908f8/rjollos.git] and comment:2, I agree those form.mod #changeinfo .options { float: left } and form.mod #changeinfo br { clear: both } styles are not useful and used.

trac/htdocs/css/trac.css

@@ -209 +209 @@
 form.mod .field.description { margin-top: 1em; }
 form.mod .field label { padding-left: .2em }
 form.mod #changeinfo .field { margin: 0.25em 0 0.75em 0 }
-form.mod #changeinfo .options { float: left; padding: 0 0 0.5em 1em }
-form.mod #changeinfo br { clear: both }
+form.mod #changeinfo .options { padding: 0 0 0.5em 1em }
 
 /* Header */
 #header hr { display: none }

[Ryan J Ollos]

Thanks for the review. Committed to trunk in [13632].