Edgewall Software
Modify

Opened 5 years ago

Closed 4 years ago

#11792 closed enhancement (fixed)

Comment text box should span the width of the enclosing fieldset

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.3
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Comment and author boxes span width of forms on wiki edit and attachment pages.

API Changes:

Description (last modified by Christian Boos)

I often find that the comment text box on the wiki edit page is too small and there is a lot of extra width within the enclosing fieldset. I propose to have the comment text box span the width of the fieldset.

Attachments (4)

#changeinfo.png (24.6 KB ) - added by Ryan J Ollos 5 years ago.
#changeinfo-1.png (14.6 KB ) - added by Ryan J Ollos 5 years ago.
AttachmentBefore.png (32.1 KB ) - added by Ryan J Ollos 5 years ago.
AttachmentAfter.png (32.0 KB ) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by Christian Boos, 5 years ago

Description: modified (diff)

by Ryan J Ollos, 5 years ago

Attachment: #changeinfo.png added

comment:2 by Ryan J Ollos, 5 years ago

Milestone: 1.0.31.1.3

Proposed changes in log:rjollos.git:t11792. I'm proposing these changes for the trunk because TagsPlugin adds an input that will likely need to be re-positioned. I haven't been able to easily test the behavior since TagsPlugin doesn't work with the trunk at the moment (AttributeError: 'Environment' object has no attribute 'get_db_cnx').

I suspect the following rules are not useful at all, but I'm hesitant to remove them unless someone else can confirm, or I find time to do more testing:

#changeinfo { clear: both }
#changeinfo br { clear: left }
#changeinfo .options, #changeinfo .buttons { clear: left }

by Ryan J Ollos, 5 years ago

Attachment: #changeinfo-1.png added

comment:3 by Ryan J Ollos, 5 years ago

Additional changes in log:rjollos.git:t11792 result in the author field spanning the width of the form.

comment:4 by Ryan J Ollos, 5 years ago

Status: newassigned

by Ryan J Ollos, 5 years ago

Attachment: AttachmentBefore.png added

by Ryan J Ollos, 5 years ago

Attachment: AttachmentAfter.png added

comment:5 by Ryan J Ollos, 5 years ago

Thinking about how the layout changes in #11813 could affect plugins, I may target these changes to 1.1.3 rather than 1.0.3.

Some additional changes in log:rjollos.git:t11792-attachment-form would force the Description input on the attachment page to fill the width of the form.

comment:6 by Jun Omae, 4 years ago

I'm trying rjollos.git:t11792-attachment-form rebased on trunk. Looks good to me.

Reading [1909908f8/rjollos.git] and comment:2, I agree those form.mod #changeinfo .options { float: left } and form.mod #changeinfo br { clear: both } styles are not useful and used.

  • trac/htdocs/css/trac.css

    diff --git a/trac/htdocs/css/trac.css b/trac/htdocs/css/trac.css
    index fe58ec0..1aba2a6 100644
    a b form.mod .field { margin: .5em 0; }  
    209209form.mod .field.description { margin-top: 1em; }
    210210form.mod .field label { padding-left: .2em }
    211211form.mod #changeinfo .field { margin: 0.25em 0 0.75em 0 }
    212 form.mod #changeinfo .options { float: left; padding: 0 0 0.5em 1em }
    213 form.mod #changeinfo br { clear: both }
     212form.mod #changeinfo .options { padding: 0 0 0.5em 1em }
    214213
    215214/* Header */
    216215#header hr { display: none }

comment:7 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks for the review. Committed to trunk in [13632].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.