Auto-preview breaks TicketExt plugin, possibily others

[chris.nelson.1022@…]

When auto-preview kicks in and new ticket content is returned via XHR, trac/ticket/templates/ticket.html uses jQuery's .replaceWith() function to update the page. This has the effect of dropping all the display: none added to the page on initial load by TicketExt.

One solution is to pass pass the XHR response through the same filters as the initial page load so the same manipulation (e.g., setting display attributes) can be applied.

Another is to change contents rather than replace the entire DOM subtree. This can be done with:

trac/ticket/templates/ticket.html

@@ -79 +79 @@
         $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) {
           var items = $(reply);
           // Update ticket box
-          $("#ticket").replaceWith(items.filter('#ticket'));
+          var newProps = $('table.properties td', items);
+          $('#ticket table.properties td').each(function(i) {
+            $(this).html(newProps.eq(i).html());
+          });
+          var newDescription = $('div.description div.searchable', items);
+          $('#ticket div.description div.searchable').html(newDescription.html());
+          if (items.hasClass('ticketdraft'))
+            $('#ticket').addClass('ticketdraft');
           // Unthread, unrevert and update changelog
           if (!$('#trac-comments-oldest').checked())
             $('#trac-comments-oldest').click().change();

though this is likely a partial fix.

(This has also been discussed at ​th:#11923.)

[Ryan J Ollos]

The issue is also seen with ​th:CondFieldsPlugin (​th:#11920). I haven't tried to reproduce the issue with ​th:DynamicFieldsPlugin, but I wouldn't be surprised if it had the same issue.

I haven't dug deep into the issue, but a cursory look suggests that since the plugin's JavaScript has already been added to the page (condfields.js in the case of ​th:CondFieldsPlugin), we just need an event to fire after the DOM is updated by autopreview, which we could use to trigger the execution of the plugin's JavaScript.

[Jun Omae]

That patch has the following problems.

• When summary is changed, its value wouldn't be changed in preview.
• When status or type is changed, its value wouldn't be changed in preview.
• When field without value is set (or value is removed from field), missing class in its header wouldn't toggle in preview.

That would make auto-preview handler more complex. I like simple.

[Jun Omae]

Sorry for deleting milestone.

[Ryan J Ollos]

Replying to jomae:

That patch has the following problems.

• When summary is changed, its value wouldn't be changed in preview.
• When status or type is changed, its value wouldn't be changed in preview.
• When field without value is set (or value is removed from field), missing class in its header wouldn't toggle in preview.

That would make auto-preview handler more complex. I like simple.

The patch wasn't intended to be complete, or even a suitable candidate for integration, see ​th:comment:6:ticket:11923.

[Ryan J Ollos]

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

[christiano@…]

I just wanted to confirm that this problem does exist in ​th:DynamicFieldsPlugin

[Ryan J Ollos]

Milestone renamed