Edgewall Software
Modify

Opened 5 years ago

Last modified 4 years ago

#11713 new defect

Repositories can still be added when no IRepositoryConnectors enabled

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-major-releases
Component: admin/web Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

When there are no IRepositoryConnectors enabled, the Manage Repositories page is still shown, including the Add Repositories fieldset. The allowed type is (default).

I propose adding a notice that No repository connectors are enabled, and to not allow a user to add a new repository.

With the following configuration in trac.ini and the MercurialConnector not enabled, the repository is displayed on the table with no indicator that it is not navigable.

[repositories]
hg-plugin.dir = /home/user/Workspace/mercurial-plugin
hg-plugin.type = hg

On the other hand, the Browser Source tab is not present and when navigating to /browser, the following text is shown in the Last Change column: TracError: Unsupported version control system "hg": Can't find an appropriate component, maybe the corresponding plugin was not enabled?. We could display something similar in the table on the Manage Repositories page.

Also, when SubversionConnector is not enabled, the following is still shown on the Add repositories form: Default: svn

Attachments (0)

Change History (3)

in reply to:  description comment:1 by Ryan J Ollos, 5 years ago

Replying to rjollos:

On the other hand, the Browser Source tab is not present and when navigating to /browser, the following text is shown in the Last Change column: TracError: Unsupported version control system "hg": Can't find an appropriate component, maybe the corresponding plugin was not enabled?. We could display something similar in the table on the Manage Repositories page.

See related comment:1:ticket:11351.

comment:2 by Ryan J Ollos, 4 years ago

Milestone: next-stable-1.0.xnext-major-releases

Another option would be to only enable the Manage Repositories panel when at least one Repository Connector is enabled.

in reply to:  2 comment:3 by Ryan J Ollos, 4 years ago

Replying to Ryan J Ollos:

Another option would be to only enable the Manage Repositories panel when at least one Repository Connector is enabled.

#12248.

I'll leave this ticket for addressing the issue of a repository being defined for a connector that is not enabled.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.