Opened 10 years ago
Last modified 5 years ago
#11713 new defect
Repositories can still be added when no IRepositoryConnectors enabled
Reported by: | Ryan J Ollos | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | next-major-releases |
Component: | admin/web | Version: | 1.0-stable |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
When there are no IRepositoryConnector
s enabled, the Manage Repositories page is still shown, including the Add Repositories fieldset. The allowed type is (default).
I propose adding a notice that No repository connectors are enabled, and to not allow a user to add a new repository.
With the following configuration in trac.ini and the MercurialConnector
not enabled, the repository is displayed on the table with no indicator that it is not navigable.
[repositories] hg-plugin.dir = /home/user/Workspace/mercurial-plugin hg-plugin.type = hg
On the other hand, the Browser Source tab is not present and when navigating to /browser
, the following text is shown in the Last Change column: TracError: Unsupported version control system "hg": Can't find an appropriate component, maybe the corresponding plugin was not enabled?. We could display something similar in the table on the Manage Repositories page.
Also, when SubversionConnector
is not enabled, the following is still shown on the Add repositories form: Default: svn
Attachments (0)
Change History (3)
comment:1 by , 10 years ago
follow-up: 3 comment:2 by , 9 years ago
Milestone: | next-stable-1.0.x → next-major-releases |
---|
Another option would be to only enable the Manage Repositories panel when at least one Repository Connector is enabled.
comment:3 by , 9 years ago
Replying to Ryan J Ollos:
Another option would be to only enable the Manage Repositories panel when at least one Repository Connector is enabled.
⇒ #12248.
I'll leave this ticket for addressing the issue of a repository being defined for a connector that is not enabled.
Replying to rjollos:
See related comment:1:ticket:11351.