Anonymous is not translated in ticket workflow hint

[Ryan J Ollos]

As mentioned in comment:1:ticket:11474, anonymous is not translated in the ticket workflow action hint. However, it is property translated in the ticket properties box.

With the proposed changes,

[Ryan J Ollos]

Committed to 1.0-stable in [13000], merged to trunk in [13001].

[Ryan J Ollos]

One additional translation-related fix in [13032], merged in [13033].

[Jun Omae]

One additional related fix in [13032], merged in [13033].

I think that the space character in suffix of "from invalid state " is intentional.

If .operations of the aciton has multiple operations in a workflow, it generates multiple control and concatinates at tags/trac-1.0.1/trac/ticket/default_workflow.py#L329​.

I think it would be good to concatinate with space at the end rather than generating a control ended with a space, attachment:t11689-render_ticket_action_control.diff​.

[Ryan J Ollos]

Thanks, that looks good. It will eliminate 1 message from the catalog that differs by only a single white-space.

Committed in [13038], merged in [13039]. New message extractions in [13040] and [13042].

[Ryan J Ollos]

It looks like we could refactor [13038] in milestone:1.0.3 with:

trac/ticket/default_workflow.py

@@ -30 +30 @@
 from trac.perm import PermissionSystem
 from trac.ticket.api import ITicketActionController, TicketSystem
 from trac.ticket.model import Resolution
+from trac.util.presentation import separated
 from trac.util.text import obfuscate_email_address
 from trac.util.translation import _, tag_, cleandoc_
 from trac.web.chrome import Chrome, add_script, add_script_data
@@ -346 +347 @@
         else:
             if status != '*':
                 hints.append(_("Next status will be '%(name)s'", name=status))
-        return (this_action['name'],
-                tag((' ' if i else None, c) for i, c in enumerate(control)),
+        return (this_action['name'], tag(separated(control, ' ')),
                 '. '.join(hints) + '.' if hints else '')
 
     def get_ticket_changes(self, req, ticket, action):

[Ryan J Ollos]

Change from comment:5 committed to 1.0-stable (1.0.3dev) in [13164], merged to trunk in [13165].