Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

#11582 closed enhancement (fixed)

Allow doctype to be specified

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: rendering Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

The HTML DocType can be specified through Chrome.html_doctype. The default is XHTML_STRICT.

Description

The proposed changed, backported from Bloodhound, would allow the HTML doctype to be set by a theme.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 5 years ago

Milestone: next-stable-1.0.x1.0.2
Owner: set to Ryan J Ollos
Status: newassigned

Proposed changes in log:rjollos.git:t11582.

comment:2 by Jun Omae, 5 years ago

Fine by me. But I'd like to be the following.

-        doctype = {'text/html': Chrome(self.env).html_doctype} \
-                  .get(content_type)
+        doctype = None
+        if content_type == 'text/html':
+            doctype = self.html_doctype

comment:3 by Ryan J Ollos, 5 years ago

Yeah, that is cleaner. Is there any use case for setting html_doctype = None, or can we just join the body of the two conditionals as I've done in log:rjollos.git:t11582.2?

comment:4 by Jun Omae, 5 years ago

I think it's quite unlikely to set html_doctype = None. Therefore rjollos.git:t11582.2 looks good to me.

comment:5 by Ryan J Ollos, 5 years ago

API Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12678] and merged to trunk in [12679].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.