Wiki toolbar should not show on disabled fields

[Wladimir Palant]

wikitoolbar.js currently contains the following initialization code:

$("textarea.wikitext").each(function() { addWikiFormattingToolbar(this) });

This will add the toolbar to all text fields, even the ones that have been disabled using ​th:BlackMagicTicketTweaksPlugin. Disabled text fields shouldn't have this toolbar however. A simple change to the line above should do:

$("textarea.wikitext:not([disabled])").each(function() { addWikiFormattingToolbar(this) });

[Ryan J Ollos]

We've previously discussed not adding the toolbar to disabled textareas, and decided to keep the current behavior: comment:10:ticket:11069. I've considered disabling the buttons on the toolbar though, to better emphasize that the textarea is disabled.

[Ryan J Ollos]

I think these changes aren't overly useful, but here are some proposed changes: log:rjollos.git:t11560.

When a user had TICKET_ADMIN but not MILESTONE_ADMIN, the textarea on the Manage Milestone page (e.g. /admin/ticket/milestones/milestone1) was disabled, but pressing the toolbar buttons added content to the textarea. This couldn't cause any harmful behaviour since the Save button was also disabled.

[Jun Omae]

In [e381ff06/rjollos.git], please don't remove call of focus(). document.selection.createRange() requires focus of the element on Internet Explorer 8 or early.

[Ryan J Ollos]

Okay, I propose to commit just the changes in log:rjollos.git:t11560.2.

[Ryan J Ollos]

It seems to be better to use prop: log:rjollos.git:t11560.3.

[Ryan J Ollos]

Committed to 1.0-stable in [12833], merged to trunk in [12834].