Opened 10 years ago
Last modified 9 years ago
#11542 closed enhancement
Deleting a resource should warn that attachments will also be deleted — at Version 9
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Milestone: | 1.1.3 |
Component: | general | Version: | 1.0-stable |
Severity: | normal | Keywords: | attachment |
Cc: | Branch: | ||
Release Notes: |
List of attachments is shown on the wiki, ticket and milestone delete pages, along with a warning that the attachments will be deleted if the resource is deleted. |
||
API Changes: | |||
Internal Changes: |
Description
Specifically, when deleting a wiki page, the wiki delete page should list the attachments that will be deleted and warn that the files are not recoverable after the parent resource is deleted.
The same behavior should probably also be applied to the Milestone and Ticket resources.
Change History (10)
follow-up: 2 comment:1 by , 10 years ago
Keywords: | attachment added |
---|
follow-up: 3 comment:2 by , 10 years ago
Replying to psuter:
Deleting a milestone does actually not seem to delete the attachments so far. (Is this a defect? Perhaps this should be changed in a separate ticket first.)
Oh, that's so bad. Trac 0.12.5 has the issue. We should fix it on 0.12-stable. Please create a new ticket.
comment:3 by , 10 years ago
by , 9 years ago
Attachment: | 20141213T105005.png added |
---|
comment:4 by , 9 years ago
I didn't use list_of_attachments.html because it seems better to present just a simple list of attachments without extra data to clutter the presentation.
If the changes look good to others I will make similar changes to:
- tags/trac-1.0.2/trac/ticket/templates/milestone_delete.html
- tags/trac-1.0.2/tracopt/ticket/templates/ticket_delete.html
Proposed changes in log:rjollos.git:t11542.
comment:5 by , 9 years ago
Note that deleting a single version might also delete the attachments (if it is the only version).
comment:7 by , 9 years ago
Milestone: | next-stable-1.0.x → 1.1.3 |
---|
comment:8 by , 9 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:9 by , 9 years ago
Release Notes: | modified (diff) |
---|
Refactoring of the wiki_delete.html
and list_of_attachments.html
templates committed in [13533].
Deleting a milestone does actually not seem to delete the attachments so far. (Is this a defect? Perhaps this should be changed in a separate ticket first.)
trac/ticket/model.py