Strange message for intertrac without link

[Jun Omae]

​http://trac.edgewall.org/demo-0.12/intertrac/r0 says the following.

Can't view r0: privileges are required to perform this operation

In this site, trac:r0 says…

Can't view r0: privileges are required to perform this operation. You don't have the required permissions.

That is wrong use of PermissionError at tags/trac-0.12.5/trac/wiki/intertrac.py@:56#L45​. The message should be specified with msg keyword argument.

trac/wiki/intertrac.py

@@ -53 +53 @@
         if isinstance(link_frag, (Element, Fragment)):
             elt = find_element(link_frag, 'href')
             if elt is None: # most probably no permissions to view
-                raise PermissionError(_("Can't view %(link)s:", link=link))
+                raise PermissionError(msg=_("Can't view %(link)s:", link=link))
             href = elt.attrib.get('href')
         else:
             href = req.href(link.rstrip(':'))

[Ryan J Ollos]

Changes were recently made on 1.0-stable to address this. See #11283. I guess I should have backported the changes to 0.12-stable.

[Jun Omae]

Thanks for pointer and suggestion. The issue doesn't exist on 1.0-stable.

But I don't want a new translation message by backport of the changes on 0.12-stable.

[Jun Omae]

I reconsider it. I think we should backport [12048] for #11283 to 0.12-stable. Also, the use of PermissionError in intertrac.py leads glitch of ​th:PermRedirectPlugin.

[Jun Omae]

Backported in [12680]

[Ryan J Ollos]

Replying to jomae:

Also, the use of PermissionError in intertrac.py leads glitch of ​th:PermRedirectPlugin.

​th:PermRedirectPlugin appear to redirect on PermissionError (​th:browser:permredirectplugin/trunk/permredirect/filter.py@12446:66#L64), but that seems expected. What issue were you seeing?

edit: Looking at this more closely now, maybe we don't want it to redirect since it may be a case of the resource not being found.

[Jun Omae]

Replying to rjollos:

edit: Looking at this more closely now, maybe we don't want it to redirect since it may be a case of the resource not being found.

Yes, you're right.

Before [12680] and [12048], Trac raises a PermissionError for non-existent resource in intertrac and the plugin redirect to login page. But Trac raises NotFound for the non-existent resource after logged in.

I think the behavior confuses the users.