AttributeError: 'NoneType' object has no attribute 'get_similar_commands'

[Ryan J Ollos]

When running the command:

trac-admin $env help $cmd

the following output results for the case that $env is not a valid environment and $cmd is not a valid command:

$ trac-admin noenv help nocmd
No documentation found for 'nocmd'. Use 'help' to see the list of commands.
AttributeError: 'NoneType' object has no attribute 'get_similar_commands'

Prior to [12277], a different error would result:

$ trac-admin noenv help nocmd
No documentation found for 'nocmd'. Use 'help' to see the list of commands.
UnboundLocalError: local variable 'cmd_mgr' referenced before assignment

Thanks to Olemis Lang for initial investigating of the issue, which was reported in bloodhound:#762.

[Jun Omae]

Thanks for investigating. Wrong handling with non-existent path on help command. I'll fix it.

[Jun Omae]

Trac 0.12.4 and later have the same issue. That is introduced in [11165].

$ ~/venv/trac/0.12.5/bin/trac-admin /notfound help nocmd
No documentation found for 'nocmd'. Use 'help' to see the list of commands.
UnboundLocalError: local variable 'cmd_mgr' referenced before assignment
$ ~/venv/trac/0.12.4/bin/trac-admin /notfound help nocmd
No documentation found for 'nocmd'. Use 'help' to see the list of commands.
UnboundLocalError: local variable 'cmd_mgr' referenced before assignment
$ ~/venv/trac/0.12.3/bin/trac-admin /notfound help nocmd
No documentation found for 'nocmd'

[Jun Omae]

Fix with unit tests in jomae.git@t11504 and jomae.git@t11504_0.12.6dev.

[Jun Omae]

Committed in [12540] and merged in [12541-12542].

[Ryan J Ollos]

The changes look good and test out well on my end. Thanks for the quick fix!