Concurrent insertion of ticket change through web interface and post-commit hook can cause inconsistencies

[Ryan J Ollos]

The issue can be seen in ​th:comment:2:ticket:11584.

• I did a git svn dcommit with a changeset that referenced ​th:#11584.
• While the commit was in process, I submitted a comment through the web interface.

Notice the numbering of the comments: comment:2 → comment:1 → comment:2. Now, when trying to edit comment:2, two edit boxes open. The notification for comment:1 was received before that for comment:2, however comment:1 appears after comment:2 and comment:1 has a larger timestamp:

<div class="change" id="trac-change-2-1392805859736008">
<div class="change" id="trac-change-1-1392805861656646">

Note also that the ticket property changes in comment:2 and comment:1 are inconsistent:

• comment:2: new → closed
• comment:1: new → accepted

… and the ticket was closed following the insertion of both changes.

[Ryan J Ollos]

I hesitated a bit in using the word concurrent when creating this defect report, for concern that I might be interpreted as claiming too much from the developer standpoint. It was effectively concurrent from the user standpoint. git-svn was doing some work, and while that was happening I hit submit on a comment I'd previously entered into the ticket.

[Ryan J Ollos]

This looks very similar to #9478, so closing as a duplicate.