Edgewall Software

Opened 9 years ago

Closed 7 years ago

Last modified 23 months ago

#11491 closed defect (duplicate)

Concurrent insertion of ticket change through web interface and post-commit hook can cause inconsistencies

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone:
Component: ticket system Version:
Severity: normal Keywords:
Cc: Jun Omae Branch:
Release Notes:
API Changes:
Internal Changes:


The issue can be seen in th:comment:2:ticket:11584.

  • I did a git svn dcommit with a changeset that referenced th:#11584.
  • While the commit was in process, I submitted a comment through the web interface.

Notice the numbering of the comments: comment:2comment:1comment:2. Now, when trying to edit comment:2, two edit boxes open. The notification for comment:1 was received before that for comment:2, however comment:1 appears after comment:2 and comment:1 has a larger timestamp:

<div class="change" id="trac-change-2-1392805859736008">
<div class="change" id="trac-change-1-1392805861656646">

Note also that the ticket property changes in comment:2 and comment:1 are inconsistent:

  • comment:2: newclosed
  • comment:1: newaccepted

… and the ticket was closed following the insertion of both changes.

Attachments (0)

Change History (3)

comment:1 by Jun Omae, 9 years ago

Cc: Jun Omae added

comment:2 by Ryan J Ollos, 9 years ago

I hesitated a bit in using the word concurrent when creating this defect report, for concern that I might be interpreted as claiming too much from the developer standpoint. It was effectively concurrent from the user standpoint. git-svn was doing some work, and while that was happening I hit submit on a comment I'd previously entered into the ticket.

comment:3 by Ryan J Ollos, 7 years ago

Milestone: next-stable-1.0.x
Resolution: duplicate
Status: newclosed

This looks very similar to #9478, so closing as a duplicate.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.