Opened 10 years ago
Closed 10 years ago
#11462 closed defect (fixed)
pretty_dateinfo is inconsistent between Chrome and TimelineModule — at Version 5
| Reported by: | Jun Omae | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | low | Milestone: | 1.0.2 |
| Component: | general | Version: | 1.0-stable |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
Fix inconsistent |
||
| API Changes: | |||
| Internal Changes: | |||
Description
pretty_dateinfo with absolute date/time is inconsistent between Chrome and TimelineModule.
If TimelineModule is enabled:
If TimelineModule is disabled (then, pretty_dateinfo in Chrome is used):
Change History (8)
by , 10 years ago
| Attachment: | disabled-timeline-module.png added |
|---|
by , 10 years ago
| Attachment: | enabled-timeline-module.png added |
|---|
comment:1 by , 10 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
by , 10 years ago
| Attachment: | PatchRenderer.png added |
|---|
comment:2 by , 10 years ago
I did some testing and the changes work well.
This is unrelated, but something I noticed while testing - for an attachment that is a patch file, the timeline link is not rendered even when TimelineModule is disabled. When viewing other file types, the timeline link is rendered.
follow-up: 4 comment:3 by , 10 years ago
That is not depended on file type. The attachment view sends ETag header using req.check_modified. After TimelineModule is enabled/disabled, try to use force-reload.
comment:4 by , 10 years ago
Replying to jomae:
After
TimelineModuleis enabled/disabled, try to use force-reload.
Yes, that is it. Thanks.
comment:5 by , 10 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Proposed fix with unit tests is in log:jomae.git@t11462.