Edgewall Software
Modify ↓

Opened 10 years ago

Closed 10 years ago

#11462 closed defect (fixed)

pretty_dateinfo is inconsistent between Chrome and TimelineModule

Reported by: Jun Omae Owned by: Jun Omae
Priority: low Milestone: 1.0.2
Component: general Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fix inconsistent pretty_dateinfo between Chrome and TimelineModule.

API Changes:
Internal Changes:

Description

pretty_dateinfo with absolute date/time is inconsistent between Chrome and TimelineModule.

If TimelineModule is enabled:

If TimelineModule is disabled (then, pretty_dateinfo in Chrome is used):

Attachments (3)

disabled-timeline-module.png​ (2.8 KB ) - added by Jun Omae 10 years ago.
enabled-timeline-module.png​ (3.3 KB ) - added by Jun Omae 10 years ago.
PatchRenderer.png​ (13.5 KB ) - added by Ryan J Ollos 10 years ago.

Download all attachments as: .zip

Change History (8)

by Jun Omae, 10 years ago

Attachment: disabled-timeline-module.png​ added

by Jun Omae, 10 years ago

Attachment: enabled-timeline-module.png​ added

comment:1 by Jun Omae, 10 years ago

Owner: set to Jun Omae
Status: new → assigned

Proposed fix with unit tests is in log:jomae.git@t11462.

Last edited 10 years ago by Jun Omae (previous) (diff)

by Ryan J Ollos, 10 years ago

Attachment: PatchRenderer.png​ added

comment:2 by Ryan J Ollos, 10 years ago

I did some testing and the changes work well.

This is unrelated, but something I noticed while testing - for an attachment that is a patch file, the timeline link is not rendered even when TimelineModule is disabled. When viewing other file types, the timeline link is rendered.

comment:3 by Jun Omae, 10 years ago

That is not depended on file type. The attachment view sends ETag header using req.check_modified. After TimelineModule is enabled/disabled, try to use force-reload.

in reply to:  3 comment:4 by Ryan J Ollos, 10 years ago

Replying to jomae:

After TimelineModule is enabled/disabled, try to use force-reload.

Yes, that is it. Thanks.

comment:5 by Jun Omae, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed in [12468] and merged to trunk in [12469]. Thanks for reviewing.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.