Edgewall Software

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#11460 closed defect (fixed)

Image macro and svn_prop.py ignore [trac] htdocs_location setting — at Version 4

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.7
Component: general Version: 0.12-stable
Severity: normal Keywords: htdocs_location
Cc: Branch:
Release Notes:
  • Uses [trac] htdocs_location option for images:
    • [[Image]] macro with non-existent attachment
    • svn:needs-lock property
  • Renamed _chrome_resource_path to chrome_resource_path as a public api
API Changes:
Internal Changes:

Description

Image macro and browser page for resources with svn:locks generate <tracenv>/chrome/common/... url. It should use [trac] htdocs_location setting. 

$ git grep 'chrome.*common/' 0.12-stable | sed -n '/tests/d; /[.]py:/p'
0.12-stable:trac/versioncontrol/svn_prop.py:        return tag.img(src=context.href.chrome('common/lock-locked.png'),
0.12-stable:trac/web/chrome.py:        `/chrome/common/`.
0.12-stable:trac/wiki/macros.py:                raw_url = formatter.href.chrome('common/attachment.png')

$ git grep 'chrome.*common/' 1.0-stable | sed -n '/tests/d; /[.]py:/p'
1.0-stable:trac/web/chrome.py:        `/chrome/common/`.
1.0-stable:trac/wiki/macros.py:                raw_url = formatter.href.chrome('common/attachment.png')
1.0-stable:tracopt/versioncontrol/svn/svn_prop.py:        return tag.img(src=context.href.chrome('common/lock-locked.png'),

$ git grep 'chrome.*common/' trunk | sed -n '/tests/d; /[.]py:/p'
trunk:trac/web/chrome.py:        `/chrome/common/`.
trunk:trac/wiki/macros.py:                raw_url = formatter.href.chrome('common/attachment.png')
trunk:tracopt/versioncontrol/svn/svn_prop.py:        return tag.img(src=context.href.chrome('common/lock-locked.png'),

Change History (4)

comment:1 by anonymous, 10 years ago

Keywords: htdocs_location added

comment:2 by Jun Omae, 9 years ago

Milestone: next-stable-1.0.x → 1.0.7
Owner: set to Jun Omae
Status: new → assigned

Proposed changes in jomae.git@t11460.

In the changes, _chrome_resource_path is renamed to chrome_resource_path to be a public api in trac.web.chrome.

comment:3 by Ryan J Ollos, 9 years ago

Changes looks good to me. All tests pass on Max OSX 10.10 with Python 2.7.

comment:4 by Jun Omae, 9 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Thanks for the reviewing. Committed in [14106] and merged to trunk in [14107].

Note: See TracTickets for help on using tickets.