Use a hidden class rather than inline style tag

[Ryan J Ollos]

I'd like to propose a minor change, of using a hidden class for at least the following cases:

$ grep -R "style=\"display: none\"" . --exclude-dir=.svn
./trac/ticket/templates/ticket.html:                <span id="trac-threaded-toggle" style="display: none">
./trac/templates/error.html:                  <ul py:if="frames" style="display: none">
./trac/templates/error.html:                      <div py:if="frame.line" class="source" style="display: none">
./trac/templates/error.html:                      <div py:if="frame.vars" class="vars" style="display: none">
./trac/templates/error.html:                  <p style="display: none"><input type="button" id="tbtoggle" value="${_('Switch to plain text view')}" /></p>

The hidden class could be added to trac.css.

[Remy Blank]

The tags with display: none are usually ones that are manipulated (i.e. shown and hidden) through jQuery, which will set the display property on the tag directly. So there's no real advantage of using a CSS class. It's actually almost a convention in Trac to mark such JavaScript-updated tags in this way.

[Ryan J Ollos]

Thanks for the input. I'll go ahead and close this then.