Wikilink to Git `log:[reponame]@[branch]` resolves branch to its tip in href
|Reported by:||Owned by:||Jun Omae|
|Component:||version control/log view||Version:||1.0-stable|
Using the wiki syntax log:rjollos.git@t10138 to link to a named branch log in a git repository results in a rendered link with an href like
/log/rjollos.git/?rev=cd20d667b7b19e3ddba88bb2406472b71de797c2: the branch name "t10138" has been replaced with a reference to its current tip.
Using the unresolved branch name in the log reference would be preferable:
- It would allow users to bookmark the resulting link. Currently if a user bookmarks the resulting link, it will become "stale" as soon as the branch tip changes, and will no longer meet the user's expectation that it shows an up-to-date log of the t10138 branch.
- It would prevent "race conditions" which can cause the link to become stale. If a user visits a wiki page that contains the
log:link, and then leaves that page open in a browser window, while another user commits and pushes changes to the t10138 branch, then the link will no longer point to the current branch tip without a page reload. If the user is very unlucky, the branch tip could even change during the lifecycle of the request to the wiki page, which means the link might even be stale right away.
This behavior is also inconsistent with browser:rjollos.git@t10138, which does result in a link to
/browser/rjollos.git?rev=t10138 and therefore always points at the branch tip.
Change History (7)
comment:2 by , 6 years ago
|Status:||new → assigned|