Modify ↓
#11426 closed defect (fixed)
Signature of expand_macro in WikiMacroBase is not correct
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12.6 |
| Component: | wiki system | Version: | |
| Severity: | normal | Keywords: | macro |
| Cc: | Branch: | ||
| Release Notes: |
Changed the function signature of |
||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
Since the trailing argument args was added, the signature of expand_macro in WikiMacroBase hasn't been updated. This isn't a big issue, but could be confusing to users of the base class.
The proposed changes have been implemented in log:rjollos.git:t11426.
Attachments (0)
Change History (4)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
comment:2 by , 10 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
comment:3 by , 10 years ago
The args exists in comment and literal in the expand_macro of sample-plugins/HelloWorld.py. I think we should change the name to content.
See source:branches/0.12-stable/sample-plugins/HelloWorld.py@12405:56,58,60#L51.
comment:4 by , 10 years ago
Note:
See TracTickets
for help on using tickets.
Committed to 0.12-stable in [12405], merged to 1.0-stable in [12406], merged to trunk in [12407].