Edgewall Software
Modify ↓

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11426 closed defect (fixed)

Signature of expand_macro in WikiMacroBase is not correct

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 0.12.6
Component: wiki system Version:
Severity: normal Keywords: macro
Cc: Branch:
Release Notes:

Changed the function signature of WikiMacroBase.expand_macro to match the IWikiMacroProvider interface that it implements.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Since the trailing argument args was added, the signature of expand_macro in WikiMacroBase hasn't been updated. This isn't a big issue, but could be confusing to users of the base class.

The proposed changes have been implemented in log:rjollos.git:t11426.

Attachments (0)

Change History (4)

comment:1 by Ryan J Ollos, 11 years ago

Description: modified (diff)
Status: new → assigned

comment:2 by Ryan J Ollos, 11 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to 0.12-stable in [12405], merged to 1.0-stable in [12406], merged to trunk in [12407].

comment:3 by Jun Omae, 11 years ago

The args exists in comment and literal in the expand_macro of sample-plugins/HelloWorld.py. I think we should change the name to content.

See source:branches/0.12-stable/sample-plugins/HelloWorld.py@12405:56,58,60#L51​.

comment:4 by Ryan J Ollos, 11 years ago

Thanks. Committed to 0.12-stable in [12411], merged to 1.0-stable in [12412], merged to trunk in [12413].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.