Definition terms in list have absolute positioning

[Ryan J Ollos]

The dt elements on the changeset and diff view pages have absolute positioning, so if someone wanted to say, add a left margin #overview { margin-left: 2.5em }, the entire contents of the dl would not be shifted:

—>

The following change seems to make sense, since it removes the absolute left position of the dts, and instead sets the margin-left on the parent to preserve their positioning.

trac/htdocs/css/diff.css

@@ -2 +2 @@
 #prefs fieldset { margin: 1em .5em .5em; padding: .5em 1em 0 }
 
 /* Diff/change overview */
-#overview { line-height: 130%; margin-top: 1em; padding: .5em }
+#overview { line-height: 130%; margin-top: 1em; padding: .5em .5em .5em 0 }
 #overview dt.property {
  font-weight: bold;
  padding-right: .25em;
  position: absolute; /* relies on #content { position: relative } */
- left: 0;
  text-align: right;
  width: 7.75em;
 }

After that change, if we set a margin-left in the custom stylesheet (#overview { margin-left: 2.5em }), we get:

There was some recent adjustments to the left property in [11097] and [11136]. Prior to that, the most recent change was [943].