Fixup whitespace on repository admin pages when saving changes

[Ryan J Ollos]

The following behaviours should be implemented to make the Repository admin page consistent with the other admin pages:

• Call simplify_whitespace on the name and alias.
• Remove leading and trailing whitespace from the directory and url.

Also:

• we should simplify whitespace on the Component owner field.
• simplify_whitespace should be extended to remove zero-width spaces (comment:5:ticket:11351).

[Ryan J Ollos]

Also there are some issues mentioned in comment:2:ticket:11351 and comment:4:ticket:11297 that we may want to explore in this ticket.

[Ryan J Ollos]

Issue reported in ​SO:23956175.

[Ryan J Ollos]

See related comment:5:ticket:11351.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[strk@…]

I just got hit by this issue too, annoying indeed as it's not easy to see there's a space in the name (dirname is unquoted in trac-admin error message too)

[Jun Omae]

Replying to Ryan J Ollos:

When attempting to add an item that differs from an existing item only by whitespace, the error shown below results. For example, if attempting to add milestone5 , but milestone5 already exists, the traceback results. We should trap this condition and raise the TracError, which is the typical situation when adding an existing item.

In trac/ticket/admin.py, we trap IntegrityError on saving an item but have not trapped on adding an item for milestone, component, version, enum record.

trac/ticket/admin.py

@@ -286 +286 @@
                             mil.due = user_time(req, parse_date,
                                                 req.args.get('duedate'),
                                                 hint='datetime')
-                        mil.insert()
-                        add_notice(req, _('The milestone "%(name)s" has been '
-                                          'added.', name=name))
+                        try:
+                            mil.insert()
+                        except self.env.db_exc.IntegrityError:
+                            raise TracError(_('Milestone "%(name)s" already '
+                                              'exists.', name=name))
+                        else:
+                            add_notice(req, _('The milestone "%(name)s" has '
+                                              'been added.', name=name))
                     else:
                         if mil.name is None:
                             raise TracError(_('Invalid milestone name.'))

Proposed changes in [a18914a42/jomae.git] (jomae.git@t11371).

[Ryan J Ollos]

comment:11 changes look good. For trunk, we'll need to catch ResourceExistsError (#11419).

[Jun Omae]

Revised proposed changes:

1.0-stable	[47fd9b5fd/jomae.git] (jomae.git@t11371_1.0)
1.2-stable	[37fc02f18/jomae.git] (jomae.git@t11371_1.2)
trunk	[a0dd4b9c9/jomae.git] (jomae.git@t11371_trunk)

[Ryan J Ollos]

The comment:13 changes look good to me.

[Jun Omae]

Thanks for the reviewing. Applied in [16502] and merged in [16503-16504].