#11336 closed enhancement (fixed)
Hide the retarget select when the milestone has no associated tickets
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.2 |
| Component: | roadmap | Version: | |
| Severity: | normal | Keywords: | milestone retarget |
| Cc: | Branch: | ||
| Release Notes: |
When editing or deleting a milestone and there are no tickets associated with the milestone, the retarget elements are not shown and a hint is shown in their place. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
It was previously discussed starting in comment:38:ticket:5658 that the retarget select should be hidden when there are no retargetable tickets associated with the milestone. This applies to the Milestone edit page and the Milestone delete page. For the Milestone edit action, any open tickets are retargetable. For the Milestone delete action, any tickets associated with the milestone are retargetable.
Attachments (9)
Change History (19)
comment:1 by , 11 years ago
| Status: | new → assigned |
|---|
by , 11 years ago
| Attachment: | DeleteMilestone1.png added |
|---|
by , 11 years ago
| Attachment: | DeleteMilestone2.png added |
|---|
by , 11 years ago
| Attachment: | DeleteMilestone2WithHint.png added |
|---|
by , 11 years ago
| Attachment: | EditMilestone3.png added |
|---|
by , 11 years ago
| Attachment: | EditMilestone4.png added |
|---|
comment:2 by , 11 years ago
comment:3 by , 11 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Committed to trunk in [12215:12217].
comment:4 by , 11 years ago
| Release Notes: | modified (diff) |
|---|
comment:5 by , 11 years ago
I've introduced a regression in that the New Milestone form shows the retarget select. The proposed fix can be found in log:rjollos.git:t11336.2.
by , 11 years ago
| Attachment: | EditMilestone6.png added |
|---|
by , 11 years ago
| Attachment: | t11336-revision.patch added |
|---|
follow-up: 9 comment:7 by , 11 years ago
I haven't been too happy with the styling of the text shown in comment:2 for There are no tickets associated with this milestone. It looks out of place. Maybe this is better (t11336-revision.patch)?
by , 11 years ago
| Attachment: | t11336-revision2.patch added |
|---|
comment:8 by , 11 years ago
Patch that includes changes to the delete confirmation page: t11336-revision2.patch.
by , 11 years ago
| Attachment: | DeleteMilestone3.png added |
|---|
comment:9 by , 11 years ago
Replying to rjollos:
I haven't been too happy with the styling of the text shown in comment:2 for There are no tickets associated with this milestone.. It looks out of place. Maybe this is better (t11336-revision.patch)?
Looks good to me. I like help styled text rather than italic.
comment:10 by , 11 years ago
| Release Notes: | modified (diff) |
|---|
Thanks for reviewing. Committed to trunk in [12539].
When I started working this ticket, I was thinking that it might not be very good practice to have elements conditionally appear on the form, as comment:description suggests should be implemented. However, that is what we are currently doing for the case that there are no milestones to which the tickets can be retargeted: tags/trac-1.0.1/trac/ticket/templates/milestone_edit.html@:82#L71. That behavior is also undesirable because the user doesn't have a choice to retarget the tickets to None vs leaving them associated with the milestone that is being closed.
I experimented with the idea of always showing the retarget elements when there are tickets associated with the milestone, even when the only choice in the selet is to retarget the tickets to the None milestone, and showing a hint when there are no tickets associated with the milestone.
Here are some screen captures. The associated changes can be found in log:rjollos.git:t11336. What do you think about replacing the retarget form elements with a hint?
Milestone delete: Tickets associated with the milestone
Milestone delete: Tickets associated with the milestone (no hint)
Milestone delete: Tickets associated with the milestone (hint)
Milestone edit: Tickets associated with the milestone
Milestone edit: Tickets associated with the milestone