#11319 closed defect (fixed)
Raising UnicodeEncodeError with unicode text for session key in prefs/advanced page
| Reported by: | Jun Omae | Owned by: | Jun Omae |
|---|---|---|---|
| Priority: | low | Milestone: | 1.0.7 |
| Component: | general | Version: | 0.12-stable |
| Severity: | normal | Keywords: | preferences |
| Cc: | Branch: | ||
| Release Notes: |
Fix raising |
||
| API Changes: | |||
| Internal Changes: | |||
Description
If submitting unicode text for session key in prefs/advanced page, UnicodeEncodeError will be raised. I think that the session key should be only ascii characters.
This issue has been originally reported in babel:#332.
Attachments (0)
Change History (11)
comment:1 by , 10 years ago
| Keywords: | preferences added |
|---|
comment:2 by , 10 years ago
| Milestone: | next-stable-1.0.x → 1.0.3 |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
comment:3 by , 10 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
comment:4 by , 9 years ago
Similar issue reported in th:#12421 and confirmed with Trac 1.0.6. Use of unicode character in session key when restoring session results in UnicodeEncodeError.
comment:5 by , 9 years ago
| Milestone: | 1.0.3 → 1.0.7 |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Hmm. It seems to be not fixed…. I'll fix it again. We should add functional tests also.
comment:6 by , 9 years ago
Proposed changes in jomae.git@t11319.2 in restore session with unicode characters for session id.
comment:7 by , 9 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
Fixed in [14120:14121] again.
comment:8 by , 9 years ago
What happens with non-anymous username accounts that have e.g. dashes in their username (e.g. "the-duke")? I've noticed some users can't log in anymore and get a Trac error instead now after upgrading to Trac 1.0.7
comment:9 by , 9 years ago
Ditto to the last commenter. This change was too restrictive—I have users whose usernames contain . for example.
follow-up: 11 comment:10 by , 9 years ago
comment:11 by , 8 years ago
Replying to Ryan J Ollos:
The issues mentioned in comment:8 and comment:9 shouldn't be seen after 1.0.8, see #12129.
Just saw this comment finally—I kept meaning to open an ticket for this but see it's already been resolved. I understand now this was only meant to apply to SIDs and not usernames. Thanks!
Proposed changes in jomae.git@t11319. After the changes, only alphanumeric characters is used for new session key. Because the new session key for anonymous will be used in cookie, I think we should add the limitation.