Edgewall Software

Opened 11 years ago

Closed 11 years ago

#11282 closed defect (fixed)

"log:" link for Git repository refers wrong commit — at Version 3

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: plugin/git Version: 1.0.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Render log: link with a missing revision as a anchor with the missing class.

API Changes:
Internal Changes:

Description

Currently, jomae.git:ticket11219/1.0-stable branch refers 505a35af. Also, /log/jomae.git/?rev=ticket11219/1.0-stable page refers correct commit.

However log: link, log:jomae.git:ticket11219/1.0-stable, refers a347405c4, not 505a35af. The link should refer 505a35af.

Change History (3)

comment:1 by Jun Omae, 11 years ago

There are two issues.

  1. log: link with missing revision is rendered as a normal link, e.g. log:jomae.git:no_such_a_revision, log:@987654321. We should render an anchor with the missing class and no href attribute.
  2. The log:jomae.git:ticket11219/1.0-stable is parsed as the numeric revisions range from ticket11219/1.0 to stable. This issue is the same as #11050.

I'll fix the first issue.

comment:2 by Jun Omae, 11 years ago

Owner: set to Jun Omae
Status: newassigned

The fix for the first issue is in log:jomae.git@ticket11282.

comment:3 by Jun Omae, 11 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Rebased the changes on current 1.0-stable branch, log:jomae.git@ticket11282.2.

Pushed in [12150] and merged to trunk in [12151].

Note: See TracTickets for help on using tickets.