Extended TestTicketHistory functional test case

[Ryan J Ollos]

When viewing a version of a page (e.g. ticket/9595) the #propertyform form and the #modify link are hidden. The TestTicketHistory​ functional test case will be extended to these behaviors.

[Ryan J Ollos]

Proposed changes in rjollos.git:t11273.

[Ryan J Ollos]

Committed to 1.0-stable in [11941:11942] and merged to trunk in [11943].

[Christian Boos]

Not entirely sure if this was due to r11941 or if the problem could have happened before, but I had a one-time failure in that test:

======================================================================
FAIL: runTest (trac.ticket.tests.functional.TestTicketHistory)
Test ticket history
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cboos/trac/1.0-stable/trac/ticket/tests/functional.py", line 178, in runTest
    tc.notfind(comment)
  File "/home/cboos/trac/1.0-stable/trac/tests/functional/better_twill.py", line 224, in better_notfind
    raise twill.errors.TwillAssertionError(*args)
TwillAssertionError: ("match to 'one.'", '/home/cboos/trac/1.0-stable/testenv/trac/log/TestTicketHistory.html', '/home/cboos/trac/1.0-stable/testenv/trac/log/TestTicketHistory.html')

Of course 'one.' is too short and was already present several time elsewhere in the page. For example, the ticket description (as seen in TestTicketHistory.html) contained:

<p>
one three seven.<br />
</p>
<p>
five five three ten two four six one.<br />
</p>
...

[Ryan J Ollos]

It looks like it was due to the refactoring I did in [11941]. Previously the random sentence would have 5 words, now it has a random number of words​.

In general, I think it would be best for FunctionalTester.add_comment to generate a comment with at least 5 words. So I propose:

• Add a min_word_count keyword argument to random_sentence.
• Call random_sentence with min_word_count=5 in FunctionalTester.add_comment.
• Run tests several dozen times locally to verify these changes before committing ;)

[Christian Boos]

Replying to rjollos:

• Run tests several dozen times locally to verify these changes before committing ;)

Well, to be really safe, we should probably add a unique id of some sort to the random content (in general). A timestamp would probably not be enough in case we add two comments in sequence, but using module uuid (new in Python 2.5) would be fine for Trac 1.0.

[Ryan J Ollos]

Replying to cboos:

Well, to be really safe, we should probably add a unique id of some sort to the random content (in general). A timestamp would probably not be enough in case we add two comments in sequence, but using module uuid (new in Python 2.5) would be fine for Trac 1.0.

I see now that this appears on Windows due to the fallback​ of not having a dictionary to import.

Did you have in mind a very simple change such as this?

trac/tests/contentgen.py

@@ -12 +12 @@
 # history and logs, available at http://trac.edgewall.org/log/.
 
 import random
-
+import uuid
 
 try:
     all_words = [x.strip() for x in open('/usr/share/dict/words').readlines() i
@@ -30 +30 @@
         'ten',
     ]
 
+
 def random_word():
     word = random.choice(all_words)
     # Do not return CamelCase words
@@ -51 +52 @@
     if word_count == None:
         word_count = random.randint(1, 20)
     words = [random_word() for x in range(word_count)]
+    words += str(uuid.uuid1())
     return '%s.' % ' '.join(words)
 
 def random_paragraph(sentence_count=None):

Those changes are prepare in rjollos.git:t11273.2. I had to make a minor change to TestTimelineTicketDetails to avoid dealing with shortening the summary of the expected result: [92287cb3/rjollos.git].

[Christian Boos]

Replying to rjollos:

Replying to cboos:

Well, to be really safe, we should probably add a unique id of some sort to the random content (in general). A timestamp would probably not be enough in case we add two comments in sequence, but using module uuid (new in Python 2.5) would be fine for Trac 1.0.

I see now that this appears on Windows due to the fallback​ of not having a dictionary to import.

Ah right, well spotted.

Did you have in mind a very simple change such as this?

Yes.

Those changes are prepare in rjollos.git:t11273.2. I had to make a minor change to TestTimelineTicketDetails to avoid dealing with shortening the summary of the expected result: [92287cb3/rjollos.git].

And what if supercalifragilisticexpialidocious is part of your dictionary?

If the uuid would be prepended instead of appended, one could deal with truncation more easily, as one could use startswith (or similar when regexps are involved).

[Ryan J Ollos]

Replying to cboos:

And what if supercalifragilisticexpialidocious is part of your dictionary?

If the uuid would be prepended instead of appended, one could deal with truncation more easily, as one could use startswith (or similar when regexps are involved).

That sounds good. I'll plan to modify the function such that the first word in the sentence is a uuid, and then wordcount-1 additional words from the dictionary are added.

[Ryan J Ollos]

I had a test case failure today while running the whole suite against the work in #11069, and the issue seems related to the discussion we've had here.

======================================================================
FAIL: Test custom textarea field with no format explicitly specified,
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/user/Workspace/t11069/teo-rjollos.git/trac/ticket/tests/functional.py", line 349, in runTest
    tc.find('<td headers="h_newfield"[^>]*>\s*%s\s*</td>' % wiki)
  File "/home/user/Workspace/t11069/teo-rjollos.git/trac/tests/functional/better_twill.py", line 216, in better_find
    raise twill.errors.TwillAssertionError(*args)
TwillAssertionError: ('no match to \'<td headers="h_newfield"[^>]*>\\s*<p>\\s*<a [^>]*>OvertaxingM\\??</a> eschewed<br />\\s*</p>\\s*</td>\'', '/home/user/Workspace/t11069/teo-rjollos.git/testenv/trac/log/TestTicketCustomFieldTextAreaWikiFormat.html')

----------------------------------------------------------------------
Ran 1337 tests in 234.683s

FAILED (failures=1)

A camelcase word was expected in the output, but OvertaxingM was generated. At least from the dictionary on Ubunutu 13.04, single letter "words" can be generated.

>>> from trac.tests import contentgen
>>> words = sorted(contentgen.all_words)
>>> for w in words:
>>>   if len(w) == 1:
>>>       print w
A
B
C
D
...

I think the solution is to add a min_length parameter to random_word, and modify random_unique_camel to call random_word(2)​.

[Ryan J Ollos]

A new set of changes to address comment:4 and comment:10 have been prepared in rjollos.git:t11273.3.

[Ryan J Ollos]

Changes in rjollos.git:t11273.3 committed to 1.0-stable in [11966:11967] and merged to trunk in [11968].