Opened 11 years ago
Last modified 10 years ago
#11268 new defect
Obfuscation of email address is not performed on search results
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | low | Milestone: | unscheduled |
| Component: | search system | Version: | 1.0.1 |
| Severity: | minor | Keywords: | email obfuscation |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
This ticket is different from #8473 (which addresses whether a search should include certain hits).
When search results are displayed, there is a short snippet of content from each hit. The email obfuscations is not performed on that snippet.
I have no personal issues with this bug, just reporting it for completeness.
Not quite sure about the version. I noticed it on this (Edgewall) trac instance.
Attachments (2)
Change History (4)
by , 11 years ago
| Attachment: | Screen Shot 2013-08-04 at 21.56.36.png added |
|---|
by , 11 years ago
| Attachment: | Screen Shot 2013-08-04 at 21.57.13.png added |
|---|
But clicking the search hit will display it with obfuscation.
comment:1 by , 11 years ago
| Keywords: | email obfuscation added |
|---|
This is really just a special case of #1502.
I did some hunting around. The preparation of the search results is done by trac.search.api.shorten_result, and we can see that it doesn't take any care to obfuscate the email addresses, or do any other wiki formatting.
On the other hand the timeline renderer calls a formatter, passing a RenderingContext. We could probably utilize the OneLineFormatter after calling shorten_result. It looks like shorten_result just attempts to extract a segment of text around the first matching term.
comment:2 by , 10 years ago
| Milestone: | → unscheduled |
|---|
Search result is not obfuscated.