malformed langauge tag in timeline rss if locale with no territory

[Jun Omae]

If locale with no territory, timeline rss has malformed langauge tag like this.

<?xml version="1.0"?>
<rss xmlns:dc="http://purl.org/dc/elements/1.1/" version="2.0">
  <channel>
    <title>0.12-stable ††</title>
    <link>http://localhost/timeline</link>
    <description>Trac Timeline</description>
    <language>ja-None</language>
    <generator>Trac 0.12.5</generator>
    <image>
      <title>0.12-stable ††</title>
      <url>http://localhost/chrome/common/trac_banner.png</url>
      <link>http://localhost/timeline</link>
    </image>
    <item>
...

trac/timeline/templates/timeline.rss

@@ -6 +6 @@
     <title>${project.name}</title>
     <link>${abs_href.timeline()}</link>
     <description>Trac Timeline</description>
-    <language>${req.locale and \
-                '%s-%s' % (req.locale.language, req.locale.territory) or \
-                'en-US'}</language>
+    <language>${locale and str(locale).replace('_', '-') or 'en-US'}</language>
     <generator>Trac ${trac.version}</generator>
     <image py:if="chrome.logo.src_abs">
       <title>${project.name}</title>

[Ryan J Ollos]

I tried out the change and it works well with Babel 0.9.6 and Python 2.4/0.12-stable, Python 2.5/1.0-stable.

I don't know that this matters, but I noticed that the territories in the ​standard-language codes linked from the ​w3 site are lowercase, whereas Babel outputs them in uppercase.

[Jun Omae]

Thanks for the feedback.

The language tag in rss 2.0 have one of ISO 639 language codes, e.g. en, or a pair of ISO 639 language code and ISO 3166 country code, .e.g. en-US. Normally, a rss application treats as case-insensitive, or does not use it ;-)

Also, I think that Babel for the identifiers follows "2.1.1. Formatting of Language Tags" in ​RFC 5646 - Tags for Identifying Languages.

[Jun Omae]

Applied in [11856] and merged in [11857-11858].